Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This uses the current node as the provider to supply the OTA image. This can be ... #12772

Closed
todo bot opened this issue Dec 9, 2021 · 3 comments
Closed
Labels
ota stale Stale issue or PR V1.X

Comments

@todo
Copy link

todo bot commented Dec 9, 2021

// TODO: This uses the current node as the provider to supply the OTA image. This can be configurable such that the provider
// supplying the response is not the provider supplying the OTA image.
FabricIndex fabricIndex = commandObj->GetExchangeContext()->GetSessionHandle().GetFabricIndex();
FabricInfo * fabricInfo = Server::GetInstance().GetFabricTable().FindFabricWithIndex(fabricIndex);
NodeId nodeId = fabricInfo->GetPeerId().GetNodeId();
// Only doing BDX transport for now
MutableCharSpan uri(uriBuf, kUriMaxLen);
GenerateBdxUri(nodeId, CharSpan(mOTAFilePath, strlen(mOTAFilePath)), uri);
ChipLogDetail(SoftwareUpdate, "Generated URI: %.*s", static_cast<int>(uri.size()), uri.data());
}


This issue was generated by todo based on a TODO comment in a3127d8 when #12636 was merged. cc @carol-apple.
@carol-apple
Copy link
Contributor

https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/4993 changed the spec wording for v1.0. Specifically:

The usage of a different Node ID than that of the provider is reserved for future use.

@stale
Copy link

stale bot commented Sep 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 5, 2022
@stale
Copy link

stale bot commented Sep 22, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ota stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

3 participants