Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CheckImageDownloadAllowed() signature and add the call to mOnQueryImageResponse #12580

Closed
selissia opened this issue Dec 4, 2021 · 1 comment
Closed

Update CheckImageDownloadAllowed() signature and add the call to mOnQueryImageResponse #12580

selissia opened this issue Dec 4, 2021 · 1 comment
Labels
p1 priority 1 work

Comments

@selissia
Copy link
Contributor

selissia commented Dec 4, 2021

Problem

CheckImageDownloadAllowed() needs to take into account image parameters

Proposed Solution

Update the function signature to be
virtual bool CheckImageDownloadAllowed(uint32 SoftwareVersion, string SoftwareVersionString, octstr UpdateToken);

Add the call to CheckImageDownloadAllowed() to mOnQueryImageResponse() using as arguments the info extracted from QueryImageResponse
@selissia selissia added the TE7.5 label Dec 4, 2021
@selissia selissia self-assigned this Dec 4, 2021
@selissia selissia added the p1 priority 1 work label Dec 4, 2021
@selissia selissia removed their assignment Dec 11, 2021
@selissia
Copy link
Contributor Author

selissia commented Jan 3, 2022

Issue no longer relevant after the refactoring done in #13210

@selissia selissia closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1 priority 1 work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@selissia