Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we should change PacketBufferTLVWriter so we can finalize it #12544

Closed
todo bot opened this issue Dec 3, 2021 · 0 comments
Closed

Maybe we should change PacketBufferTLVWriter so we can finalize it #12544

todo bot opened this issue Dec 3, 2021 · 0 comments
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Dec 3, 2021

// TODO Maybe we should change PacketBufferTLVWriter so we can finalize it
// but have it hold on to the buffer, and get the buffer from it later.
// Then we could avoid this extra pointer-sized member.
System::PacketBufferHandle mPendingInvokeData;
// If mTimedInvokeTimeoutMs has a value, we are expected to do a timed
// invoke.
Optional<uint16_t> mTimedInvokeTimeoutMs;
TLV::TLVType mDataElementContainerType = TLV::kTLVType_NotSpecified;
bool mSuppressResponse = false;
bool mTimedRequest = false;


This issue was generated by todo based on a TODO comment in 4711edd when #12465 was merged. cc @bzbarsky-apple.
@todo todo bot added the todo label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants