Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate use of DNS cache #11632

Closed
cecille opened this issue Nov 10, 2021 · 2 comments
Closed

Evaluate use of DNS cache #11632

cecille opened this issue Nov 10, 2021 · 2 comments
Assignees
Labels

Comments

@cecille
Copy link
Contributor

cecille commented Nov 10, 2021

Problem

It's not clear what the purpose of the cache is or how it should be sized - the TTL on most entries would be only 2 minutes and nodes should be querying only very specific nodes they want to connect to. Many larger devices will be using an mdns impl that already includes caching. See discussion on #11149.

Proposed Solution

I think there is utility in leaving the code there in case there are cases we have not considered, but we may want to consider turning it off by default.

@andy31415
Copy link
Contributor

Assigned to me as I believe I am touching this as part of mDNS resolution logic (I need to have a 'get best address' logic and the DNS caching is actually in the way in parts). Not working to really fix it, but it may be touched as a sideffect.

@andy31415
Copy link
Contributor

We removed the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants