Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Group message counter here spec 4.7.3 #11025

Closed
todo bot opened this issue Oct 27, 2021 · 1 comment
Closed

Handle Group message counter here spec 4.7.3 #11025

todo bot opened this issue Oct 27, 2021 · 1 comment
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Oct 27, 2021

// TODO: Handle Group message counter here spec 4.7.3
// spec 4.5.1.2 for msg counter
// Trial decryption with GroupDataProvider. TODO: Implement the GroupDataProvider Class
// VerifyOrExit(CHIP_NO_ERROR == groups->DecryptMessage(packetHeader, payloadHeader, msg),
// ChipLogError(Inet, "Secure transport received group message, but failed to decode it, discarding"));
if (isDuplicate == SessionManagerDelegate::DuplicateMessage::Yes && !payloadHeader.NeedsAck())
{
ChipLogDetail(Inet,
"Received a duplicate message with MessageCounter:" ChipLogFormatMessageCounter


This issue was generated by todo based on a TODO comment in 07627cf when #10985 was merged. cc @jepenven-silabs.
@todo todo bot added the todo label Oct 27, 2021
@todo todo bot reopened this Nov 5, 2021
@todo
Copy link
Author

todo bot commented Nov 5, 2021

This issue has been reopened because the TODO comment still exists in src/transport/SessionManager.cpp, as of 9144e5d.


If this was not intentional, just remove the comment from your code. You can also set the reopenClosed config if you don't want this to happen at all anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants