Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag optional fields in the OTA clusters as optional in the xml #10892

Closed
bzbarsky-apple opened this issue Oct 23, 2021 · 4 comments
Closed

Flag optional fields in the OTA clusters as optional in the xml #10892

bzbarsky-apple opened this issue Oct 23, 2021 · 4 comments

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

The OTA cluster XML does not flag fields (in structs, commands) as optional as defined in the spec.

Proposed Solution

Do it. I'll do it after #10891 so we have cluster-objects support for this.
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 23, 2021
Merged
@bzbarsky-apple
Copy link
Contributor Author

In particular OTA QueryImage has an optional field.

@bzbarsky-apple
Copy link
Contributor Author

QueryImageResponse has some too, but to fix that we need to change how the OTA requestor sends its QueryImage command...

@bzbarsky-apple
Copy link
Contributor Author

#11243 fixes the QueryImage bit.

@bzbarsky-apple
Copy link
Contributor Author

Fixed in #11336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bzbarsky-apple