From e0021745e8871d985c8a4b461e24412e50617c3b Mon Sep 17 00:00:00 2001 From: Dieter Van der Meulen <87530904+dvdm-qorvo@users.noreply.github.com> Date: Wed, 16 Nov 2022 17:18:59 +0100 Subject: [PATCH] Change BLE notifications to indications for QPG (#23635) --- .gitmodules | 2 +- src/platform/qpg/BLEManagerImpl.cpp | 6 +++--- third_party/qpg_sdk/repo | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitmodules b/.gitmodules index 5b8d0b466a3b40..0da2aaa3ce495a 100644 --- a/.gitmodules +++ b/.gitmodules @@ -52,7 +52,7 @@ [submodule "qpg_sdk"] path = third_party/qpg_sdk/repo url = https://github.com/Qorvo/QMatter - branch = v0.9.0.0-libs + branch = vlatest-libs platforms = qpg [submodule "zap"] path = third_party/zap/repo diff --git a/src/platform/qpg/BLEManagerImpl.cpp b/src/platform/qpg/BLEManagerImpl.cpp index f466491ff724c8..2c7d7a0adfcf4b 100644 --- a/src/platform/qpg/BLEManagerImpl.cpp +++ b/src/platform/qpg/BLEManagerImpl.cpp @@ -292,17 +292,17 @@ bool BLEManagerImpl::SendIndication(BLE_CONNECTION_OBJECT conId, const ChipBleUU uint16_t dataLen = data->DataLength(); VerifyOrExit(IsSubscribed(conId), err = CHIP_ERROR_INVALID_ARGUMENT); - ChipLogDetail(DeviceLayer, "Sending notification for CHIPoBLE Client TX (con %u, len %u)", conId, dataLen); + ChipLogDetail(DeviceLayer, "Sending indication for CHIPoBLE Client TX (con %u, len %u)", conId, dataLen); isRxHandle = UUIDsMatch(&chipUUID_CHIPoBLEChar_RX, charId); cId = qvCHIP_BleGetHandle(isRxHandle); - qvCHIP_BleSendNotification(conId, cId, dataLen, data->Start()); + qvCHIP_BleSendIndication(conId, cId, dataLen, data->Start()); exit: if (err != CHIP_NO_ERROR) { - ChipLogError(DeviceLayer, "BLEManagerImpl::SendNotification() failed: %s", ErrorStr(err)); + ChipLogError(DeviceLayer, "BLEManagerImpl::SendIndication() failed: %s", ErrorStr(err)); return false; } return true; diff --git a/third_party/qpg_sdk/repo b/third_party/qpg_sdk/repo index 8aadeb12092272..617a0b065592c0 160000 --- a/third_party/qpg_sdk/repo +++ b/third_party/qpg_sdk/repo @@ -1 +1 @@ -Subproject commit 8aadeb120922720aba2bf0be8d5230d979856a4e +Subproject commit 617a0b065592c0bd298d28e4b275c830b91b3d7b