From d425b8f4beb25d40aec1d66e72b6d3c7e6ef4fab Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Fri, 10 Mar 2023 18:59:14 -0500 Subject: [PATCH] Disable the shared-reviwers-signify group for now. (#25627) Due to https://github.com/dropseed/pullapprove/issues/71 it's causing PRs to land with an insufficient number of reviews. --- .pullapprove.yml | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index 74eee17032a03e..f92717408353a7 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -144,14 +144,20 @@ groups: teams: [reviewers-samsung] reviews: request: 10 - shared-reviewers-signify: - type: optional - conditions: - - files.include('*') - reviewers: - teams: [reviewers-signify] - reviews: - request: 10 + # shared-reviewers-signify disabled for now, because the reviewers-signify + # team is empty and pullapprove seems to mis-handle that badly and treats + # _all_ reviewers as being in this group. + # + # See https://github.com/dropseed/pullapprove/issues/71 + # + # shared-reviewers-signify: + # type: optional + # conditions: + # - files.include('*') + # reviewers: + # teams: [reviewers-signify] + # reviews: + # request: 10 shared-reviewers-silabs: type: optional conditions: