From c41924e8eca97937ea855db896c78a9814cd727c Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Wed, 6 Apr 2022 09:21:52 -1000 Subject: [PATCH] Remove built-in dnssd cache (#17114) Existing is already set to 0 across all platforms. Implementation was only ever supported by the PlatformDnssd implementation, which generally have their own cache (like avahi or bonjour). --- src/app/CASESessionManager.cpp | 40 +--- src/app/CASESessionManager.h | 4 - src/app/server/Server.cpp | 3 - .../CHIPDeviceControllerFactory.cpp | 5 +- src/lib/core/CHIPConfig.h | 12 -- src/lib/dnssd/BUILD.gn | 1 - src/lib/dnssd/Discovery_ImplPlatform.cpp | 1 - src/lib/dnssd/Discovery_ImplPlatform.h | 1 - src/lib/dnssd/DnssdCache.h | 187 ------------------ src/lib/dnssd/tests/BUILD.gn | 3 - src/lib/dnssd/tests/TestDnssdCache.cpp | 159 --------------- src/platform/Ameba/SystemPlatformConfig.h | 1 - src/platform/EFR32/SystemPlatformConfig.h | 2 - src/platform/ESP32/SystemPlatformConfig.h | 2 - src/platform/Linux/SystemPlatformConfig.h | 2 - src/platform/P6/SystemPlatformConfig.h | 2 - src/platform/Tizen/SystemPlatformConfig.h | 2 - .../cc13x2_26x2/SystemPlatformConfig.h | 1 - src/platform/mbed/SystemPlatformConfig.h | 2 - .../nrfconnect/SystemPlatformConfig.h | 2 - .../nxp/k32w/k32w0/SystemPlatformConfig.h | 2 - src/platform/qpg/SystemPlatformConfig.h | 2 - src/platform/telink/SystemPlatformConfig.h | 2 - src/platform/webos/SystemPlatformConfig.h | 2 - 24 files changed, 4 insertions(+), 436 deletions(-) delete mode 100644 src/lib/dnssd/DnssdCache.h delete mode 100644 src/lib/dnssd/tests/TestDnssdCache.cpp diff --git a/src/app/CASESessionManager.cpp b/src/app/CASESessionManager.cpp index 3e0f9e140501f9..02f6ea1ced98b8 100644 --- a/src/app/CASESessionManager.cpp +++ b/src/app/CASESessionManager.cpp @@ -33,31 +33,15 @@ CHIP_ERROR CASESessionManager::FindOrEstablishSession(PeerId peerId, Callback::C { Dnssd::ResolvedNodeData resolutionData; - bool nodeIDWasResolved = -#if CHIP_CONFIG_MDNS_CACHE_SIZE > 0 - (mConfig.dnsCache != nullptr && mConfig.dnsCache->Lookup(peerId, resolutionData) == CHIP_NO_ERROR); -#else - false; -#endif - - ChipLogDetail(CASESessionManager, - "FindOrEstablishSession: PeerId = " ChipLogFormatX64 ":" ChipLogFormatX64 ", NodeIdWasResolved = %d", - ChipLogValueX64(peerId.GetCompressedFabricId()), ChipLogValueX64(peerId.GetNodeId()), nodeIDWasResolved); + ChipLogDetail(CASESessionManager, "FindOrEstablishSession: PeerId = " ChipLogFormatX64 ":" ChipLogFormatX64, + ChipLogValueX64(peerId.GetCompressedFabricId()), ChipLogValueX64(peerId.GetNodeId())); OperationalDeviceProxy * session = FindExistingSession(peerId); if (session == nullptr) { ChipLogDetail(CASESessionManager, "FindOrEstablishSession: No existing session found"); - // TODO - Implement LRU to evict least recently used session to handle mActiveSessions pool exhaustion - if (nodeIDWasResolved) - { - session = mConfig.devicePool->Allocate(mConfig.sessionInitParams, peerId, resolutionData); - } - else - { - session = mConfig.devicePool->Allocate(mConfig.sessionInitParams, peerId); - } + session = mConfig.devicePool->Allocate(mConfig.sessionInitParams, peerId); if (session == nullptr) { @@ -65,10 +49,6 @@ CHIP_ERROR CASESessionManager::FindOrEstablishSession(PeerId peerId, Callback::C return CHIP_ERROR_NO_MEMORY; } } - else if (nodeIDWasResolved) - { - session->OnNodeIdResolved(resolutionData); - } CHIP_ERROR err = session->Connect(onConnection, onFailure); if (err != CHIP_NO_ERROR) @@ -97,20 +77,6 @@ void CASESessionManager::ReleaseAllSessions() CHIP_ERROR CASESessionManager::GetPeerAddress(PeerId peerId, Transport::PeerAddress & addr) { -#if CHIP_CONFIG_MDNS_CACHE_SIZE > 0 - if (mConfig.dnsCache != nullptr) - { - Dnssd::ResolvedNodeData resolutionData; - // TODO(andy31415): DNS caching is generally not populated, need to move - // caching into a the address resolve layer and not have a global one anymore. - if (mConfig.dnsCache->Lookup(peerId, resolutionData) == CHIP_NO_ERROR) - { - addr = OperationalDeviceProxy::ToPeerAddress(resolutionData); - return CHIP_NO_ERROR; - } - } -#endif - OperationalDeviceProxy * session = FindExistingSession(peerId); VerifyOrReturnError(session != nullptr, CHIP_ERROR_NOT_CONNECTED); addr = session->GetPeerAddress(); diff --git a/src/app/CASESessionManager.h b/src/app/CASESessionManager.h index 8842e3ffaf0c77..09395288df8cd5 100644 --- a/src/app/CASESessionManager.h +++ b/src/app/CASESessionManager.h @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -35,9 +34,6 @@ namespace chip { struct CASESessionManagerConfig { DeviceProxyInitParams sessionInitParams; -#if CHIP_CONFIG_MDNS_CACHE_SIZE > 0 - Dnssd::DnssdCache * dnsCache = nullptr; -#endif OperationalDeviceProxyPoolDelegate * devicePool = nullptr; }; diff --git a/src/app/server/Server.cpp b/src/app/server/Server.cpp index d51cbc3a9ee400..002e32cc99a606 100644 --- a/src/app/server/Server.cpp +++ b/src/app/server/Server.cpp @@ -244,9 +244,6 @@ CHIP_ERROR Server::Init(const ServerInitParams & initParams) .clientPool = &mCASEClientPool, .groupDataProvider = mGroupsProvider, }, -#if CHIP_CONFIG_MDNS_CACHE_SIZE > 0 - .dnsCache = nullptr, -#endif .devicePool = &mDevicePool, }; diff --git a/src/controller/CHIPDeviceControllerFactory.cpp b/src/controller/CHIPDeviceControllerFactory.cpp index 3d14de5de624e2..18e2c08ede8851 100644 --- a/src/controller/CHIPDeviceControllerFactory.cpp +++ b/src/controller/CHIPDeviceControllerFactory.cpp @@ -233,10 +233,7 @@ CHIP_ERROR DeviceControllerFactory::InitSystemState(FactoryInitParams params) CASESessionManagerConfig sessionManagerConfig = { .sessionInitParams = deviceInitParams, -#if CHIP_CONFIG_MDNS_CACHE_SIZE > 0 - .dnsCache = NoSuchThingWeWouldNeedToAddIt, -#endif - .devicePool = stateParams.operationalDevicePool, + .devicePool = stateParams.operationalDevicePool, }; // TODO: Need to be able to create a CASESessionManagerConfig here! diff --git a/src/lib/core/CHIPConfig.h b/src/lib/core/CHIPConfig.h index b5a7d0ca1b5377..f48fdd9f2f120b 100644 --- a/src/lib/core/CHIPConfig.h +++ b/src/lib/core/CHIPConfig.h @@ -1320,18 +1320,6 @@ extern const char CHIP_NON_PRODUCTION_MARKER[]; #define CHIP_COMMISSIONING_HINT_INDEX_PRESS_RESET_UNTIL_BLINK_WITH_POWER 11 #endif -/** - * @def CHIP_CONFIG_MDNS_CACHE_SIZE - * - * @brief - * Define the size of the MDNS cache - * - * If CHIP_CONFIG_MDNS_CACHE_SIZE is 0, the builtin cache is not used. - * - */ -#ifndef CHIP_CONFIG_MDNS_CACHE_SIZE -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 -#endif /** * @name Interaction Model object pool configuration. * diff --git a/src/lib/dnssd/BUILD.gn b/src/lib/dnssd/BUILD.gn index d4ce965ba4cd77..90f92dd0fa0272 100644 --- a/src/lib/dnssd/BUILD.gn +++ b/src/lib/dnssd/BUILD.gn @@ -31,7 +31,6 @@ static_library("dnssd") { sources = [ "Advertiser.h", - "DnssdCache.h", "Resolver.h", "ServiceNaming.cpp", "ServiceNaming.h", diff --git a/src/lib/dnssd/Discovery_ImplPlatform.cpp b/src/lib/dnssd/Discovery_ImplPlatform.cpp index eee9518c930fb5..b54f1c1a5f1e05 100644 --- a/src/lib/dnssd/Discovery_ImplPlatform.cpp +++ b/src/lib/dnssd/Discovery_ImplPlatform.cpp @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include diff --git a/src/lib/dnssd/Discovery_ImplPlatform.h b/src/lib/dnssd/Discovery_ImplPlatform.h index c070acc9681a1b..a4970c9c9d74d1 100644 --- a/src/lib/dnssd/Discovery_ImplPlatform.h +++ b/src/lib/dnssd/Discovery_ImplPlatform.h @@ -21,7 +21,6 @@ #include #include #include -#include #include #include #include diff --git a/src/lib/dnssd/DnssdCache.h b/src/lib/dnssd/DnssdCache.h deleted file mode 100644 index bdbb23433ef36a..00000000000000 --- a/src/lib/dnssd/DnssdCache.h +++ /dev/null @@ -1,187 +0,0 @@ -/* - * - * Copyright (c) 2021 Project CHIP Authors - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#pragma once - -#include - -#include -#include -#include -#include -#include -#include - -// set MDNS_LOGGING to enable logging -- sometimes used in debug/test programs -- traces the behavior -#ifdef MDNS_LOGGING -#define MdnsLogProgress ChipLogProgress -#else -#define MdnsLogProgress(...) -#endif - -namespace chip { -namespace Dnssd { - -template -class DnssdCache -{ -public: - DnssdCache() : elementsUsed(CACHE_SIZE) - { - for (ResolvedNodeData & e : mLookupTable) - { - // each unused entry decrements the count - MarkEntryUnused(e); - } - MdnsLogProgress(Discovery, "construct mdns cache of size %ld", CACHE_SIZE); - } - - // insert this entry into the cache. - // return error if cache is full - // TODO: have an eviction policy so if the cache is full, an entry may be deleted. - // One policy may be Least-time-to-live - CHIP_ERROR Insert(const ResolvedNodeData & nodeData) - { - const System::Clock::Timestamp currentTime = System::SystemClock().GetMonotonicTimestamp(); - - ResolvedNodeData * entry; - - entry = FindPeerId(nodeData.mPeerId, currentTime); - if (entry) - { - *entry = nodeData; - return CHIP_NO_ERROR; - } - - VerifyOrReturnError(entry = findSlot(currentTime), CHIP_ERROR_TOO_MANY_KEYS); - - // have a free slot for this entry - *entry = nodeData; - elementsUsed++; - - return CHIP_NO_ERROR; - } - - CHIP_ERROR Delete(PeerId peerId) - { - ResolvedNodeData * pentry; - const System::Clock::Timestamp currentTime = System::SystemClock().GetMonotonicTimestamp(); - - VerifyOrReturnError(pentry = FindPeerId(peerId, currentTime), CHIP_ERROR_KEY_NOT_FOUND); - - MarkEntryUnused(*pentry); - return CHIP_NO_ERROR; - } - - // given a peerId, find the parameters if its in the cache, or return error - CHIP_ERROR Lookup(PeerId peerId, ResolvedNodeData & nodeData) - { - ResolvedNodeData * pentry; - const System::Clock::Timestamp currentTime = System::SystemClock().GetMonotonicTimestamp(); - - VerifyOrReturnError(pentry = FindPeerId(peerId, currentTime), CHIP_ERROR_KEY_NOT_FOUND); - - nodeData = *pentry; - - return CHIP_NO_ERROR; - } - - // only useful if MDNS_LOGGING is set. If not used, should be optimized out - void DumpCache() - { - int i = 0; - - MdnsLogProgress(Discovery, "cache size = %d", elementsUsed); - for (ResolvedNodeData & e : mLookupTable) - { - if (e.mPeerId == nullPeerId) - { - MdnsLogProgress(Discovery, "Entry %d unused", i); - } - else - { - MdnsLogProgress(Discovery, "Entry %d: node %lx fabric %lx, port = %d", i, e.mPeerId.GetNodeId(), - e.peerId.GetFabricId(), e.port); - for (size_t j = 0; j < e.mNumIPs; ++j) - { - char address[Inet::IPAddress::kMaxStringLength]; - e.mAddress[i].ToString(address); - MdnsLogProgress(Discovery, " address %d: %s", j, address); - } - } - i++; - } - } - -private: - PeerId nullPeerId; // indicates a cache entry is unused - int elementsUsed; // running count of how many entries are used -- for a sanity check - - ResolvedNodeData mLookupTable[CACHE_SIZE]; - - ResolvedNodeData * findSlot(System::Clock::Timestamp currentTime) - { - for (ResolvedNodeData & entry : mLookupTable) - { - if (entry.mPeerId == nullPeerId) - return &entry; - - if (entry.mExpiryTime <= currentTime) - { - MarkEntryUnused(entry); - return &entry; - } - } - return nullptr; - } - - ResolvedNodeData * FindPeerId(PeerId peerId, System::Clock::Timestamp current_time) - { - for (ResolvedNodeData & entry : mLookupTable) - { - if (entry.mPeerId == peerId) - { - if (entry.mExpiryTime < current_time) - { - MarkEntryUnused(entry); - break; // return nullptr - } - return &entry; - } - if (entry.mPeerId != nullPeerId && entry.mExpiryTime < current_time) - { - MarkEntryUnused(entry); - } - } - - return nullptr; - } - - // have a method to mark ununused -- so its easy to change - void MarkEntryUnused(ResolvedNodeData & pentry) - { - pentry.mPeerId = nullPeerId; - elementsUsed--; - } -}; - -#ifndef MDNS_LOGGING -#undef MdnsLogProgress -#endif - -} // namespace Dnssd -} // namespace chip diff --git a/src/lib/dnssd/tests/BUILD.gn b/src/lib/dnssd/tests/BUILD.gn index 57910816825001..b4183ef6027a1d 100644 --- a/src/lib/dnssd/tests/BUILD.gn +++ b/src/lib/dnssd/tests/BUILD.gn @@ -26,9 +26,6 @@ chip_test_suite("tests") { "TestTxtFields.cpp", ] - if (chip_device_platform != "efr32") { - test_sources += [ "TestDnssdCache.cpp" ] - } if (chip_mdns == "minimal") { test_sources += [ "TestActiveResolveAttempts.cpp" ] } diff --git a/src/lib/dnssd/tests/TestDnssdCache.cpp b/src/lib/dnssd/tests/TestDnssdCache.cpp deleted file mode 100644 index 05334a8d5da884..00000000000000 --- a/src/lib/dnssd/tests/TestDnssdCache.cpp +++ /dev/null @@ -1,159 +0,0 @@ -/* - * - * Copyright (c) 2021 Project CHIP Authors - * All rights reserved. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -// set this to 1 to enable DumpCache to see the state of the cache when needed -// #define MDNS_LOGGING 1 -#include -#include -#include - -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#define NL_TEST_DEF_FN(fn) NL_TEST_DEF("Test " #fn, fn) - -using namespace chip; -using namespace chip::Dnssd; - -namespace { -System::Clock::Internal::MockClock fakeClock; -System::Clock::ClockBase * realClock; -} // namespace - -void TestCreate(nlTestSuite * inSuite, void * inContext) -{ - DnssdCache<10> tDnssdCache; - tDnssdCache.DumpCache(); -} - -void TestInsert(nlTestSuite * inSuite, void * inContext) -{ - const int sizeOfCache = 5; - DnssdCache tDnssdCache; - PeerId peerId; - int64_t id = 0x100; - uint16_t port = 2000; - const System::Clock::Timestamp ttl = System::Clock::Seconds16(2); - const uint64_t KNOWN_FABRIC = 0x100; - ResolvedNodeData nodeData; - ResolvedNodeData nodeDataOut; - - Inet::IPAddress::FromString("1.0.0.1", nodeData.mAddress[nodeData.mNumIPs++]); - - nodeData.mInterfaceId = Inet::InterfaceId::Null(); - nodeData.mExpiryTime = fakeClock.GetMonotonicTimestamp() + ttl; - - peerId.SetCompressedFabricId(KNOWN_FABRIC); - nodeData.mPeerId.SetCompressedFabricId(KNOWN_FABRIC); - - for (uint16_t i = 0; i < 10; i++) - { - CHIP_ERROR result; - nodeData.mPeerId.SetNodeId(static_cast(id + i)); - // Need to re-cast to uint16_t because of integer type promotion - nodeData.mPort = static_cast(port + i); - result = tDnssdCache.Insert(nodeData); - if (i < sizeOfCache) - { - NL_TEST_ASSERT(inSuite, result == CHIP_NO_ERROR); - } - else - { - NL_TEST_ASSERT(inSuite, result != CHIP_NO_ERROR); - } - } - - tDnssdCache.DumpCache(); - fakeClock.SetMonotonic(nodeData.mExpiryTime + ttl + System::Clock::Seconds16(1)); - nodeData.mExpiryTime = fakeClock.GetMonotonicTimestamp() + ttl; - - id = 0x200; - port = 3000; - for (uint16_t i = 0; i < sizeOfCache; i++) - { - CHIP_ERROR result; - - nodeData.mPeerId.SetNodeId(static_cast(id + i)); - nodeData.mPort = static_cast(port + i); - result = tDnssdCache.Insert(nodeData); - NL_TEST_ASSERT(inSuite, result == CHIP_NO_ERROR); - } - tDnssdCache.DumpCache(); - - for (uint16_t i = 0; i < sizeOfCache; i++) - { - CHIP_ERROR result; - peerId.SetNodeId(static_cast(id + i)); - result = tDnssdCache.Delete(peerId); - NL_TEST_ASSERT(inSuite, result == CHIP_NO_ERROR); - } - - tDnssdCache.DumpCache(); - - // ipv6 inserts - Inet::IPAddress::FromString("::1", nodeData.mAddress[nodeData.mNumIPs++]); - port = 4000; - for (uint16_t i = 0; i < sizeOfCache; i++) - { - CHIP_ERROR result; - - nodeData.mPeerId.SetNodeId(static_cast(id + i)); - nodeData.mPort = static_cast(port + i); - - result = tDnssdCache.Insert(nodeData); - NL_TEST_ASSERT(inSuite, result == CHIP_NO_ERROR); - } - - tDnssdCache.DumpCache(); - - NL_TEST_ASSERT(inSuite, tDnssdCache.Lookup(peerId, nodeDataOut) == CHIP_NO_ERROR); - peerId.SetCompressedFabricId(KNOWN_FABRIC + 1); - NL_TEST_ASSERT(inSuite, tDnssdCache.Lookup(peerId, nodeDataOut) != CHIP_NO_ERROR); -} - -static const nlTest sTests[] = { NL_TEST_DEF_FN(TestCreate), NL_TEST_DEF_FN(TestInsert), NL_TEST_SENTINEL() }; - -static int TestSetup(void * inContext) -{ - realClock = &System::SystemClock(); - System::Clock::Internal::SetSystemClockForTesting(&fakeClock); - return SUCCESS; -} - -static int TestTeardown(void * inContext) -{ - System::Clock::Internal::SetSystemClockForTesting(realClock); - return SUCCESS; -} - -int TestDnssdCache(void) -{ - nlTestSuite theSuite = { "MDNS Cache Creation", &sTests[0], TestSetup, TestTeardown }; - - nlTestRunner(&theSuite, nullptr); - return nlTestRunnerStats(&theSuite); -} - -CHIP_REGISTER_TEST_SUITE(TestDnssdCache) diff --git a/src/platform/Ameba/SystemPlatformConfig.h b/src/platform/Ameba/SystemPlatformConfig.h index 7db088f4a77d77..61fb892a58acb6 100755 --- a/src/platform/Ameba/SystemPlatformConfig.h +++ b/src/platform/Ameba/SystemPlatformConfig.h @@ -61,4 +61,3 @@ struct ChipDeviceEvent; #define CHIP_SYSTEM_CONFIG_USE_SOCKETS 0 #define CHIP_SYSTEM_CONFIG_USE_NETWORK_FRAMEWORK 0 #define CHIP_SYSTEM_CONFIG_POSIX_LOCKING 0 -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/EFR32/SystemPlatformConfig.h b/src/platform/EFR32/SystemPlatformConfig.h index 05cc85c872dc4d..ab83dbca1b435e 100644 --- a/src/platform/EFR32/SystemPlatformConfig.h +++ b/src/platform/EFR32/SystemPlatformConfig.h @@ -43,5 +43,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/ESP32/SystemPlatformConfig.h b/src/platform/ESP32/SystemPlatformConfig.h index 34ed45cc8aa76d..8606c505279516 100644 --- a/src/platform/ESP32/SystemPlatformConfig.h +++ b/src/platform/ESP32/SystemPlatformConfig.h @@ -47,5 +47,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS CONFIG_NUM_TIMERS #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/Linux/SystemPlatformConfig.h b/src/platform/Linux/SystemPlatformConfig.h index 1dcf357521dff3..9d4d02f92fc83d 100644 --- a/src/platform/Linux/SystemPlatformConfig.h +++ b/src/platform/Linux/SystemPlatformConfig.h @@ -45,5 +45,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/P6/SystemPlatformConfig.h b/src/platform/P6/SystemPlatformConfig.h index e37527cadfef3d..deba3447ffcf67 100644 --- a/src/platform/P6/SystemPlatformConfig.h +++ b/src/platform/P6/SystemPlatformConfig.h @@ -54,5 +54,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/Tizen/SystemPlatformConfig.h b/src/platform/Tizen/SystemPlatformConfig.h index 7a49ab8c277c34..f895bff0b9c972 100644 --- a/src/platform/Tizen/SystemPlatformConfig.h +++ b/src/platform/Tizen/SystemPlatformConfig.h @@ -47,5 +47,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/cc13x2_26x2/SystemPlatformConfig.h b/src/platform/cc13x2_26x2/SystemPlatformConfig.h index e66eeaeeb1cae5..7c3eb4d4d958a4 100644 --- a/src/platform/cc13x2_26x2/SystemPlatformConfig.h +++ b/src/platform/cc13x2_26x2/SystemPlatformConfig.h @@ -38,4 +38,3 @@ struct ChipDeviceEvent; #define CHIP_SYSTEM_CONFIG_EVENT_OBJECT_TYPE const struct ::chip::DeviceLayer::ChipDeviceEvent * // ========== Platform-specific Configuration Overrides ========= -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/mbed/SystemPlatformConfig.h b/src/platform/mbed/SystemPlatformConfig.h index 0ca39de5790290..9d4a520f7cf07c 100644 --- a/src/platform/mbed/SystemPlatformConfig.h +++ b/src/platform/mbed/SystemPlatformConfig.h @@ -47,5 +47,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/nrfconnect/SystemPlatformConfig.h b/src/platform/nrfconnect/SystemPlatformConfig.h index 001a90b8627258..ec4ba9e2f1ea90 100644 --- a/src/platform/nrfconnect/SystemPlatformConfig.h +++ b/src/platform/nrfconnect/SystemPlatformConfig.h @@ -56,5 +56,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/nxp/k32w/k32w0/SystemPlatformConfig.h b/src/platform/nxp/k32w/k32w0/SystemPlatformConfig.h index 833cc88ea9b9e3..d1b09b1f70c58f 100644 --- a/src/platform/nxp/k32w/k32w0/SystemPlatformConfig.h +++ b/src/platform/nxp/k32w/k32w0/SystemPlatformConfig.h @@ -43,5 +43,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/qpg/SystemPlatformConfig.h b/src/platform/qpg/SystemPlatformConfig.h index 0972796ff08b34..70f20518c77909 100644 --- a/src/platform/qpg/SystemPlatformConfig.h +++ b/src/platform/qpg/SystemPlatformConfig.h @@ -41,5 +41,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/telink/SystemPlatformConfig.h b/src/platform/telink/SystemPlatformConfig.h index 30e47b700390e1..f81b07573b378d 100644 --- a/src/platform/telink/SystemPlatformConfig.h +++ b/src/platform/telink/SystemPlatformConfig.h @@ -56,5 +56,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0 diff --git a/src/platform/webos/SystemPlatformConfig.h b/src/platform/webos/SystemPlatformConfig.h index bf9d871c6d89b0..f225657f9f0a21 100644 --- a/src/platform/webos/SystemPlatformConfig.h +++ b/src/platform/webos/SystemPlatformConfig.h @@ -45,5 +45,3 @@ struct ChipDeviceEvent; #ifndef CHIP_SYSTEM_CONFIG_NUM_TIMERS #define CHIP_SYSTEM_CONFIG_NUM_TIMERS 16 #endif // CHIP_SYSTEM_CONFIG_NUM_TIMERS - -#define CHIP_CONFIG_MDNS_CACHE_SIZE 0