diff --git a/src/credentials/tests/TestDeviceAttestationCredentials.cpp b/src/credentials/tests/TestDeviceAttestationCredentials.cpp index 28549eb9b55d31..7ad7d6cd30ad9e 100644 --- a/src/credentials/tests/TestDeviceAttestationCredentials.cpp +++ b/src/credentials/tests/TestDeviceAttestationCredentials.cpp @@ -358,7 +358,7 @@ static void TestAttestationTrustStore(nlTestSuite * inSuite, void * inContext) ByteSpan kPaaFFF1BadSkidSpan1{ TestCerts::sTestCert_PAA_FFF1_Cert.data(), TestCerts::sTestCert_PAA_FFF1_Cert.size() - 1 }; // SKID to trigger CHIP_ERROR_INVALID_ARGUMENT - ByteSpan kPaaFFF1BadSkidSpan2{ nullptr, TestCerts::sTestCert_PAA_FFF1_Cert.size() }; + ByteSpan kPaaFFF1BadSkidSpan2; // SKID to trigger CHIP_ERROR_CA_CERT_NOT_FOUND uint8_t kPaaGoodSkidNotPresent[] = { 0x6A, 0xFD, 0x22, 0x77, 0x1F, 0x51, 0x71, 0x1F, 0xEC, 0xBF, diff --git a/src/lib/support/tests/TestThreadOperationalDataset.cpp b/src/lib/support/tests/TestThreadOperationalDataset.cpp index 24586f39234b64..69e28cd912a382 100644 --- a/src/lib/support/tests/TestThreadOperationalDataset.cpp +++ b/src/lib/support/tests/TestThreadOperationalDataset.cpp @@ -28,7 +28,8 @@ void TestInit(nlTestSuite * inSuite, void * inContext) { Thread::OperationalDataset & dataset = *static_cast(inContext); - NL_TEST_ASSERT(inSuite, dataset.Init(ByteSpan(nullptr, 255)) == CHIP_ERROR_INVALID_ARGUMENT); + uint8_t longerThanOperationalDatasetSize[255]{}; + NL_TEST_ASSERT(inSuite, dataset.Init(ByteSpan(longerThanOperationalDatasetSize)) == CHIP_ERROR_INVALID_ARGUMENT); NL_TEST_ASSERT(inSuite, dataset.Init(ByteSpan(nullptr, 0)) == CHIP_NO_ERROR); { diff --git a/src/transport/CryptoContext.cpp b/src/transport/CryptoContext.cpp index 6b39af59696028..451bd37e438d9b 100644 --- a/src/transport/CryptoContext.cpp +++ b/src/transport/CryptoContext.cpp @@ -69,9 +69,7 @@ CHIP_ERROR CryptoContext::InitFromSecret(SessionKeystore & keystore, const ByteS SessionInfoType infoType, SessionRole role) { VerifyOrReturnError(mKeyAvailable == false, CHIP_ERROR_INCORRECT_STATE); - VerifyOrReturnError(secret.data() != nullptr, CHIP_ERROR_INVALID_ARGUMENT); VerifyOrReturnError(secret.size() > 0, CHIP_ERROR_INVALID_ARGUMENT); - VerifyOrReturnError((salt.size() == 0) || (salt.data() != nullptr), CHIP_ERROR_INVALID_ARGUMENT); ByteSpan info = (infoType == SessionInfoType::kSessionResumption) ? ByteSpan(RSEKeysInfo) : ByteSpan(SEKeysInfo); diff --git a/src/transport/tests/TestSecureSession.cpp b/src/transport/tests/TestSecureSession.cpp index d6efc341ee4fc9..466e60526369bd 100644 --- a/src/transport/tests/TestSecureSession.cpp +++ b/src/transport/tests/TestSecureSession.cpp @@ -46,12 +46,6 @@ void SecureChannelInitTest(nlTestSuite * inSuite, void * inContext) P256Keypair keypair2; NL_TEST_ASSERT(inSuite, keypair2.Initialize(ECPKeyTarget::ECDH) == CHIP_NO_ERROR); - // Test all combinations of invalid parameters - NL_TEST_ASSERT(inSuite, - channel.InitFromKeyPair(sessionKeystore, keypair, keypair2.Pubkey(), ByteSpan(nullptr, 10), - CryptoContext::SessionInfoType::kSessionEstablishment, - CryptoContext::SessionRole::kInitiator) == CHIP_ERROR_INVALID_ARGUMENT); - // Test the channel is successfully created with valid parameters NL_TEST_ASSERT(inSuite, channel.InitFromKeyPair(sessionKeystore, keypair, keypair2.Pubkey(), ByteSpan(nullptr, 0),