From 7cd14a36565e255e91941358fb8693cc0ee192e1 Mon Sep 17 00:00:00 2001 From: Vivien Nicolas Date: Fri, 12 May 2023 20:40:03 +0200 Subject: [PATCH] [chiptool.py] Make sure to update the exit code properly if parsing fails (#26539) --- .../py_matter_yamltests/matter_yamltests/parser_builder.py | 6 +++--- scripts/py_matter_yamltests/matter_yamltests/runner.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/py_matter_yamltests/matter_yamltests/parser_builder.py b/scripts/py_matter_yamltests/matter_yamltests/parser_builder.py index 72ebae6a1fff8f..2305900d5a1435 100644 --- a/scripts/py_matter_yamltests/matter_yamltests/parser_builder.py +++ b/scripts/py_matter_yamltests/matter_yamltests/parser_builder.py @@ -66,7 +66,7 @@ def __init__(self, config: TestParserBuilderConfig = TestParserBuilderConfig()): self.__tests = copy.copy(config.tests) self.__config = config self.__duration = 0 - self.__done = False + self.done = False def __iter__(self): self.__config.hooks.start(len(self.__tests)) @@ -76,9 +76,9 @@ def __next__(self): if len(self.__tests): return self.__get_test_parser(self.__tests.pop(0)) - if not self.__done: + if not self.done: self.__config.hooks.stop(round(self.__duration)) - self.__done = True + self.done = True raise StopIteration diff --git a/scripts/py_matter_yamltests/matter_yamltests/runner.py b/scripts/py_matter_yamltests/matter_yamltests/runner.py index fe4a091bc9676f..f87f94d53dc993 100644 --- a/scripts/py_matter_yamltests/matter_yamltests/runner.py +++ b/scripts/py_matter_yamltests/matter_yamltests/runner.py @@ -155,7 +155,7 @@ def run(self, parser_builder_config: TestParserBuilderConfig, runner_config: Tes duration = round((time.time() - start) * 1000) runner_config.hooks.stop(duration) - return True + return parser_builder.done async def _run(self, parser: TestParser, config: TestRunnerConfig): status = True