From 7795877cc427c5926eba5b1c74d4becdca9f92e9 Mon Sep 17 00:00:00 2001
From: Shubham Patil <shubham.patil@espressif.com>
Date: Wed, 6 Apr 2022 19:36:28 +0530
Subject: [PATCH] [ESP32] Fix ota file path and update ota provider readme with
 ACL (#17092)

requirements
---
 examples/ota-provider-app/esp32/README.md     | 28 +++++++++++++++++++
 examples/ota-provider-app/esp32/main/main.cpp |  2 +-
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/examples/ota-provider-app/esp32/README.md b/examples/ota-provider-app/esp32/README.md
index af830a81c95c45..7b4d541a5c0a2d 100644
--- a/examples/ota-provider-app/esp32/README.md
+++ b/examples/ota-provider-app/esp32/README.md
@@ -41,6 +41,34 @@ idf.py -p <OTAProviderSerialPort> flash
 ./out/debug/chip-tool pairing ble-wifi 12345 <ssid> <passphrase> 20202021 3841
 ```
 
+## Access control list requirements
+
+Commissioner or Administrator should install necessary ACL entries at
+commissioning time or later to enable processing of QueryImage commands from OTA
+Requestors on their fabric, otherwise that OTA Provider will not be usable by
+OTA Requestors.
+
+Since the ACL attribute contains a list of entries, we cannot append a single
+entry to it. So, read the ACL entries and append an entry which grants operate
+privileges to all nodes for the OTA Provider cluster (0x0029) on every endpoint.
+
+-   Read the ACL attribute
+
+```
+./out/debug/chip-tool accesscontrol read acl 12345 0
+```
+
+-   Write the ACL attribute
+
+```
+out/chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null}, {"fabricIndex": 1, "privilege": 3, "authMode": 2, "subjects": null, "targets": [{"cluster": 41, "endpoint": null, "deviceType": null}]}]' 12345 0
+```
+
+First entry created as part of commissioning which grants administer privilege
+to the node ID 112233 (default controller node ID) for all clusters on every
+endpoint. Seconds entry is the new entry being added which grants operate
+privileges to all nodes for the OTA Provider cluster (0x0029) on every endpoint
+
 ## Set delayed action time (Optional)
 
 -   Set delayed action time in the Query Image Response and Apply Update
diff --git a/examples/ota-provider-app/esp32/main/main.cpp b/examples/ota-provider-app/esp32/main/main.cpp
index 23e3ef84770656..e4396b226f16f9 100644
--- a/examples/ota-provider-app/esp32/main/main.cpp
+++ b/examples/ota-provider-app/esp32/main/main.cpp
@@ -128,7 +128,7 @@ static void InitServer(intptr_t context)
     if (otaImageLen > 0)
     {
         otaProvider.SetQueryImageStatus(OTAQueryStatus::kUpdateAvailable);
-        otaProvider.SetOTAFilePath(otaFilename);
+        otaProvider.SetOTAFilePath(otaImagePath);
     }
 
     chip::app::Clusters::OTAProvider::SetDelegate(kOtaProviderEndpoint, &otaProvider);