From 6691245cc9610260ea64cc8c55bdbb938452d944 Mon Sep 17 00:00:00 2001
From: Andrei Litvin <andy314@gmail.com>
Date: Fri, 3 Jun 2022 14:50:19 -0400
Subject: [PATCH] Add better mandatory cluster rules in matterlint (#19165)

* Add better mandatory cluster rules in matterlint

* Code review updates - do not make network commissioning required
---
 scripts/rules.matterlint | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/scripts/rules.matterlint b/scripts/rules.matterlint
index b2fa3245788f1e..3c93551496148f 100644
--- a/scripts/rules.matterlint
+++ b/scripts/rules.matterlint
@@ -79,9 +79,25 @@ all endpoints {
 
 endpoint 0 {
   // Identifiers for clusters are loaded from XML files
+  // The required clusters are from the spec for RootNode (section 2.1.5 at the moment):
+
   require server cluster Basic;
+  require server cluster AccessControl;
   require server cluster GroupKeyManagement;
-  require server cluster NetworkCommissioning;
   require server cluster GeneralCommissioning;
-  require server cluster OTASoftwareUpdateRequestor;
+  require server cluster AdministratorCommissioning;
+  require server cluster OperationalCredentials;
+  require server cluster GeneralDiagnostics;
+
+  // Required only if !CustomNetworkConfig. 
+  // require server cluster NetworkCommissioning;
+
+  // If Ethernet
+  // require server cluster EthernetNetworkDiagnostics;
+
+  // If WiFi
+  // require server cluster WiFiNetworkDiagnostics;
+
+  // If Thread
+  // require server cluster ThreadNetworkDiagnostics;
 }