From 6013644bf729c5ad84f1a7407168550d54318449 Mon Sep 17 00:00:00 2001 From: cpagravel Date: Wed, 29 Jun 2022 06:50:32 -0700 Subject: [PATCH] Chef - Continue instead of breaking on build error (#19988) --- examples/chef/chef.py | 10 ++++++++-- integrations/cloudbuild/chef.yaml | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/examples/chef/chef.py b/examples/chef/chef.py index 9de079a43a3108..a14c92781f08cd 100755 --- a/examples/chef/chef.py +++ b/examples/chef/chef.py @@ -322,6 +322,8 @@ def main(argv: Sequence[str]) -> None: dest="use_zzz", action="store_true") parser.add_option("", "--build_all", help="For use in CD only. Builds and bundles all chef examples for the specified platform. Uses --use_zzz. Chef exits after completion.", dest="build_all", action="store_true") + parser.add_option("-k", "--keep_going", help="For use in CD only. Continues building all sample apps in the event of an error.", + dest="keep_going", action="store_true") parser.add_option( "", "--ci", help="Builds Chef examples defined in cicd_config. Uses --use_zzz. Uses specified target from -t. Chef exits after completion.", dest="ci", action="store_true") @@ -387,13 +389,17 @@ def main(argv: Sequence[str]) -> None: except RuntimeError as build_fail_error: failed_builds.append((device_name, platform, "build")) flush_print(str(build_fail_error)) - break + if not options.keep_going: + exit(1) + continue try: bundle(platform, device_name) except FileNotFoundError as bundle_fail_error: failed_builds.append((device_name, platform, "bundle")) flush_print(str(bundle_fail_error)) - break + if not options.keep_going: + exit(1) + continue archive_name = f"{label}-{device_name}" archive_full_name = archive_prefix + archive_name + archive_suffix flush_print(f"Adding build output to archive {archive_full_name}") diff --git a/integrations/cloudbuild/chef.yaml b/integrations/cloudbuild/chef.yaml index 26f3123cc8588b..3d0d22900b0f5c 100644 --- a/integrations/cloudbuild/chef.yaml +++ b/integrations/cloudbuild/chef.yaml @@ -17,7 +17,7 @@ steps: - PW_ENVIRONMENT_ROOT=/pwenv args: - >- - ./examples/chef/chef.py --build_all + ./examples/chef/chef.py --build_all --keep_going id: CompileAll waitFor: - Bootstrap