From 4398403c9391d3672c8dea0630c60b94347a5846 Mon Sep 17 00:00:00 2001 From: Boris Zbarsky Date: Fri, 22 Sep 2023 14:16:54 -0400 Subject: [PATCH] Don't use LwIP defines if CHIP_SYSTEM_CONFIG_USE_LWIP is not set. (#29408) * Don't use LwIP defines if CHIP_SYSTEM_CONFIG_USE_LWIP is not set. Fixes https://github.com/project-chip/connectedhomeip/issues/29211 * Address review comment. --- src/messaging/ReliableMessageProtocolConfig.h | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/messaging/ReliableMessageProtocolConfig.h b/src/messaging/ReliableMessageProtocolConfig.h index bd0e421933a3a1..a49740ad4d5227 100644 --- a/src/messaging/ReliableMessageProtocolConfig.h +++ b/src/messaging/ReliableMessageProtocolConfig.h @@ -25,10 +25,15 @@ */ #pragma once +#include #include #include #include +#if CHIP_SYSTEM_CONFIG_USE_LWIP +#include +#endif // CHIP_SYSTEM_CONFIG_USE_LWIP + namespace chip { /** @@ -122,15 +127,23 @@ namespace chip { * */ #ifndef CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE -#if LWIP_PBUF_FROM_CUSTOM_POOLS -#define CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS -#elif PBUF_POOL_SIZE +#if CHIP_SYSTEM_CONFIG_USE_LWIP + +#if !LWIP_PBUF_FROM_CUSTOM_POOLS && PBUF_POOL_SIZE != 0 #define CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE std::min(PBUF_POOL_SIZE, CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS) -#elif CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE != 0 +#else +#define CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS +#endif // !LWIP_PBUF_FROM_CUSTOM_POOLS && PBUF_POOL_SIZE != 0 + +#else // CHIP_SYSTEM_CONFIG_USE_LWIP + +#if CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE != 0 #define CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE std::min(CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE, CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS) #else #define CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS -#endif // PBUF_POOL_SIZE +#endif // CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE != 0 + +#endif // CHIP_SYSTEM_CONFIG_USE_LWIP #endif // CHIP_CONFIG_RMP_RETRANS_TABLE_SIZE /**