From 42e77d705f2759cca4c0cc392ce1567f4f6ad55f Mon Sep 17 00:00:00 2001 From: Yufeng Wang Date: Mon, 15 Jul 2024 13:32:20 -0700 Subject: [PATCH] Address review comments --- examples/fabric-admin/rpc/RpcClient.cpp | 3 ++- examples/fabric-bridge-app/linux/RpcClient.cpp | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/fabric-admin/rpc/RpcClient.cpp b/examples/fabric-admin/rpc/RpcClient.cpp index be9ba23df57b3f..00ca1204cc1f19 100644 --- a/examples/fabric-admin/rpc/RpcClient.cpp +++ b/examples/fabric-admin/rpc/RpcClient.cpp @@ -49,7 +49,8 @@ std::condition_variable responseCv; bool responseReceived = false; CHIP_ERROR responseError = CHIP_NO_ERROR; -// By passing the `call` parameter into WaitForResponse we are explicitly trying to insure the caller takes into consideration that the lifetime of the `call` object when calling WaitForResponse +// By passing the `call` parameter into WaitForResponse we are explicitly trying to insure the caller takes into consideration that +// the lifetime of the `call` object when calling WaitForResponse template CHIP_ERROR WaitForResponse(CallType & call) { diff --git a/examples/fabric-bridge-app/linux/RpcClient.cpp b/examples/fabric-bridge-app/linux/RpcClient.cpp index d31bbbfa9156e3..02916b87aaa06a 100644 --- a/examples/fabric-bridge-app/linux/RpcClient.cpp +++ b/examples/fabric-bridge-app/linux/RpcClient.cpp @@ -49,7 +49,8 @@ std::condition_variable responseCv; bool responseReceived = false; CHIP_ERROR responseError = CHIP_NO_ERROR; -// By passing the call object to WaitForResponse to keep RPC call alive until it completes or timeout. +// By passing the `call` parameter into WaitForResponse we are explicitly trying to insure the caller takes into consideration that +// the lifetime of the `call` object when calling WaitForResponse template CHIP_ERROR WaitForResponse(CallType & call) {