From 20ee19757c9595e4056760fe73b8800e2fbcdbd7 Mon Sep 17 00:00:00 2001
From: Kevin Schoedel <67607049+kpschoedel@users.noreply.github.com>
Date: Wed, 8 Dec 2021 16:16:52 -0500
Subject: [PATCH] Remove ObjectPool leak flag from
 GroupDataProviderImpl::mKeySetIterators (#12734)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#### Problem

The `ObjectPool` leak reported in #12503 _ObjectPool leaks in
GroupDataProviderImpl_ is no longer reproducable; possibly fixed
by d25a3ef9.

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
---
 src/credentials/GroupDataProviderImpl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/credentials/GroupDataProviderImpl.h b/src/credentials/GroupDataProviderImpl.h
index cbd25f78d4d07f..24a1b9883cf57b 100644
--- a/src/credentials/GroupDataProviderImpl.h
+++ b/src/credentials/GroupDataProviderImpl.h
@@ -160,7 +160,7 @@ class GroupDataProviderImpl : public GroupDataProvider
     BitMapObjectPool<GroupMappingIteratorImpl, kIteratorsMax> mEndpointGroupsIterators;
     BitMapObjectPool<AllStatesIterator, kIteratorsMax> mAllStatesIterators;
     BitMapObjectPool<FabricStatesIterator, kIteratorsMax> mFabricStatesIterators;
-    BitMapObjectPool<KeySetIteratorImpl, kIteratorsMax, OnObjectPoolDestruction::IgnoreUnsafeDoNotUseInNewCode> mKeySetIterators;
+    BitMapObjectPool<KeySetIteratorImpl, kIteratorsMax> mKeySetIterators;
 };
 
 } // namespace Credentials