From 1612836d189790e48d3584d1313cd280100480c4 Mon Sep 17 00:00:00 2001
From: Terence Hampson <thampson@google.com>
Date: Fri, 29 Sep 2023 10:57:16 -0400
Subject: [PATCH] Remove include_yamltests arg, and always install the whl for
 python tests (#29456)

* Remove include_yamltests arg, and install always for python tests

* CI fixes

* CI fixes
---
 .github/workflows/tests.yaml |  2 +-
 scripts/build_python.sh      | 20 +++++++-------------
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
index 7d4ae2bfbe2b46..2274cd3a30872f 100644
--- a/.github/workflows/tests.yaml
+++ b/.github/workflows/tests.yaml
@@ -184,7 +184,7 @@ jobs:
                     "
             - name: Build Apps
               run: |
-                  scripts/run_in_build_env.sh './scripts/build_python.sh --install_virtual_env out/venv --include_yamltests'
+                  scripts/run_in_build_env.sh './scripts/build_python.sh --install_virtual_env out/venv'
                   ./scripts/run_in_build_env.sh \
                      "./scripts/build/build_examples.py \
                         --target linux-x64-chip-tool${CHIP_TOOL_VARIANT}-${BUILD_VARIANT} \
diff --git a/scripts/build_python.sh b/scripts/build_python.sh
index e0fa8303f72403..6965cecad3dd6f 100755
--- a/scripts/build_python.sh
+++ b/scripts/build_python.sh
@@ -68,7 +68,6 @@ Input Options:
                                                             src/python_testing scripts.
                                                             Defaults to yes.
   --extra_packages PACKAGES                                 Install extra Python packages from PyPI
-  --include_yamltests                                       Whether to install the matter_yamltests wheel.
   -z --pregen_dir DIRECTORY                                 Directory where generated zap files have been pre-generated.
 "
 }
@@ -129,9 +128,6 @@ while (($#)); do
             extra_packages=$2
             shift
             ;;
-        --include_yamltests)
-            include_yamltests="yes"
-            ;;
         --pregen_dir | -z)
             pregen_dir=$2
             shift
@@ -187,15 +183,6 @@ else
     WHEEL=("$OUTPUT_ROOT"/controller/python/chip*.whl)
 fi
 
-if [ -n "$include_yamltests" ]; then
-    YAMLTESTS_GN_LABEL="//scripts:matter_yamltests_distribution._build_wheel"
-
-    # Add wheels from pw_python_package or pw_python_distribution templates.
-    WHEEL+=(
-        "$(ls -tr "$(wheel_output_dir "$YAMLTESTS_GN_LABEL")"/*.whl | head -n 1)"
-    )
-fi
-
 if [ -n "$extra_packages" ]; then
     WHEEL+=("$extra_packages")
 fi
@@ -217,7 +204,14 @@ if [ -n "$install_virtual_env" ]; then
     "$ENVIRONMENT_ROOT"/bin/pip install --upgrade "${WHEEL[@]}"
 
     if [ "$install_pytest_requirements" = "yes" ]; then
+        YAMLTESTS_GN_LABEL="//scripts:matter_yamltests_distribution._build_wheel"
+        # Add wheels from pw_python_package or pw_python_distribution templates.
+        YAMLTEST_WHEEL=(
+            "$(ls -tr "$(wheel_output_dir "$YAMLTESTS_GN_LABEL")"/*.whl | head -n 1)"
+        )
+
         echo_blue "Installing python test dependencies ..."
+        "$ENVIRONMENT_ROOT"/bin/pip install --upgrade "${YAMLTEST_WHEEL[@]}"
         "$ENVIRONMENT_ROOT"/bin/pip install -r "$CHIP_ROOT/scripts/tests/requirements.txt"
         "$ENVIRONMENT_ROOT"/bin/pip install -r "$CHIP_ROOT/src/python_testing/requirements.txt"
     fi