From 1610428a1f34e196cbbc2b9420e2974ed96b3419 Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Thu, 11 Apr 2024 13:02:32 -0400 Subject: [PATCH] Fix typos in boostrap.sh comments, stop using path as a variable name (#32944) * Fix typos in boostrap.sh comments * Rename path to submodule_path --- scripts/setup/bootstrap.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/setup/bootstrap.sh b/scripts/setup/bootstrap.sh index 0fb9af207e2c77..23b8087ff54460 100644 --- a/scripts/setup/bootstrap.sh +++ b/scripts/setup/bootstrap.sh @@ -57,19 +57,19 @@ _install_additional_pip_requirements() { } _submodules_need_updating() { - # Validates if a set o submodules that should always be checked out are up to date + # Validates if a set of submodules that should always be checked out are up to date. - # Pigweed will be up to date on an initial setup, however it may change over time - # the rest are a small subset of things that are always checked out (have no platform attachment) + # Pigweed will be up to date on an initial setup, however it may change over time. + # The rest are a small subset of things that are always checked out (have no platform attachment). _SUBMODULE_PATHS=( "third_party/pigweed/repo" "third_party/openthread/repo" "third_party/editline/repo" ) - for path in "${_SUBMODULE_PATHS[@]}"; do - if git submodule status "$path" | grep -E '^-' >/dev/null 2>&1; then - echo "git shows that $path has changes" + for submodule_path in "${_SUBMODULE_PATHS[@]}"; do + if git submodule status "$submodule_path" | grep -E '^-' >/dev/null 2>&1; then + echo "git shows that $submodule_path has changes" unset _SUBMODULE_PATHS return 0 # Success fi