From 141aa0746e1abaae98eaef2b9c4ffc606e927687 Mon Sep 17 00:00:00 2001 From: lpbeliveau-silabs Date: Mon, 24 Jul 2023 09:47:37 -0400 Subject: [PATCH] Fix commented code and comment syntax --- src/app/reporting/SynchronizedReportSchedulerImpl.cpp | 4 ++-- src/app/tests/TestReadInteraction.cpp | 4 ++-- src/app/tests/TestReportScheduler.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/app/reporting/SynchronizedReportSchedulerImpl.cpp b/src/app/reporting/SynchronizedReportSchedulerImpl.cpp index b7fb7f664fa19e..e8591d37bf2299 100644 --- a/src/app/reporting/SynchronizedReportSchedulerImpl.cpp +++ b/src/app/reporting/SynchronizedReportSchedulerImpl.cpp @@ -183,8 +183,8 @@ void SynchronizedReportSchedulerImpl::TimerFired() { InteractionModelEngine::GetInstance()->GetReportingEngine().ScheduleRun(); - // Timestamp now = mTimerDelegate->GetCurrentMonotonicTimestamp(); - // ChipLogProgress(DataManagement, "Engine run at time: %" PRIu64 " for Handlers:", now.count()); + Timestamp now = mTimerDelegate->GetCurrentMonotonicTimestamp(); + ChipLogProgress(DataManagement, "Engine run at time: %" PRIu64 " for Handlers:", now.count()); mNodesPool.ForEachActiveObject([](ReadHandlerNode * node) { if (node->IsReportableNow()) { diff --git a/src/app/tests/TestReadInteraction.cpp b/src/app/tests/TestReadInteraction.cpp index 13bb3623afff39..f886d6ead65bd8 100644 --- a/src/app/tests/TestReadInteraction.cpp +++ b/src/app/tests/TestReadInteraction.cpp @@ -1836,8 +1836,8 @@ void TestReadInteraction::TestSubscribeUrgentWildcardEvent(nlTestSuite * apSuite NL_TEST_ASSERT(apSuite, !delegate.mGotEventResponse); NL_TEST_ASSERT(apSuite, !nonUrgentDelegate.mGotEventResponse); - // min-interval should have elapsed for urgen subscription, and our handler should still - // not be dirty or even reportable. + // The min-interval should have elapsed for urgen subscription, and our handler should still + // not be dirty or reportable. NL_TEST_ASSERT(apSuite, reportScheduler->GetMinTimestampForHandler(delegate.mpReadHandler) < System::SystemClock().GetMonotonicTimestamp()); diff --git a/src/app/tests/TestReportScheduler.cpp b/src/app/tests/TestReportScheduler.cpp index 4a76ebbbe13eaf..28bbe3c414d240 100644 --- a/src/app/tests/TestReportScheduler.cpp +++ b/src/app/tests/TestReportScheduler.cpp @@ -555,7 +555,7 @@ class TestReportScheduler // Confirm behavior when a read handler becomes dirty readHandler2->ForceDirtyState(); - // OnBecome Reportable should have been called on ForceDirtyState because readHandler callbacks are now integrated + // OnBecomeReportable should have been called on ForceDirtyState because readHandler callbacks are now integrated NL_TEST_ASSERT(aSuite, !syncScheduler.IsReportableNow(readHandler2)); NL_TEST_ASSERT(aSuite, !syncScheduler.IsReportableNow(readHandler1)); // Simulate wait enough for min timestamp of readHandler2 to be reached (1s) @@ -763,7 +763,7 @@ class TestReportScheduler NL_TEST_ASSERT(aSuite, CHIP_NO_ERROR == readHandler1->SetMinReportingIntervalForTests(0)); readHandler1->MoveToState(ReadHandler::HandlerState::GeneratingReports); syncScheduler.OnReadHandlerCreated(readHandler1); - // Forcing the dirty flag to will make the scheduler call Engine::ScheduleRun() immediately + // Forcing the dirty flag to make the scheduler call Engine::ScheduleRun() immediately readHandler1->ForceDirtyState(); NL_TEST_ASSERT(aSuite, syncScheduler.IsReportableNow(readHandler1));