fixed files form Closure #29

program-repair · Mar 7, 2017 · 791990e · 791990e
1 parent 33095a0
commit 791990e
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/projects/Closure/29/com/google/javascript/jscomp/InlineObjectLiterals.java b/projects/Closure/29/com/google/javascript/jscomp/InlineObjectLiterals.java
@@ -154,6 +154,7 @@ private boolean isVarInlineForbidden(Var var) {
      */
     private boolean isInlinableObject(List<Reference> refs) {
       boolean ret = false;
+      Set<String> validProperties = Sets.newHashSet();
       for (Reference ref : refs) {
         Node name = ref.getNode();
         Node parent = ref.getParent();
@@ -178,6 +179,14 @@ private boolean isInlinableObject(List<Reference> refs) {
           // We short-circuit this problem by bailing out if we see a reference
           // to a property that isn't defined on the object literal. This
           // isn't a perfect algorithm, but it should catch most cases.
+          String propName = parent.getLastChild().getString();
+          if (!validProperties.contains(propName)) {
+            if (NodeUtil.isVarOrSimpleAssignLhs(parent, gramps)) {
+              validProperties.add(propName);
+            } else {
+              return false;
+            }
+          }
           continue;
         }
 
@@ -213,6 +222,7 @@ private boolean isInlinableObject(List<Reference> refs) {
             return false;
           }
 
+          validProperties.add(child.getString());
 
           Node childVal = child.getFirstChild();
           // Check if childVal is the parent of any of the passed in