Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_id instead of id on firestore plugin #59

Open
Onurbon opened this issue Sep 12, 2019 · 1 comment
Open

_id instead of id on firestore plugin #59

Onurbon opened this issue Sep 12, 2019 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@Onurbon
Copy link
Contributor

Onurbon commented Sep 12, 2019

How do we feel about using _id instead of id?
Motivations:

  • it would indicate more clearly that _id is a special thing introduced (and managed) by the firestore plugin
  • it would feel more consistent with _fetching and _notFound
  • if users also want to use they own alternative notion of id, they can just have both in the same object.
@coffee-cup
Copy link
Collaborator

I am personally not a fan of underscore properties, but not strongly against it. I just think it is a bit unnecessary.

@coffee-cup coffee-cup added the enhancement ✨ New feature or request label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants