Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore plugin: Partial type for set #56

Open
coffee-cup opened this issue Sep 12, 2019 · 0 comments
Open

firestore plugin: Partial type for set #56

coffee-cup opened this issue Sep 12, 2019 · 0 comments
Assignees
@coffee-cup
Labels
enhancement ✨ New feature or request

Comments

@coffee-cup
Copy link
Collaborator

When updating a document (.set), you shouldn't be required to pass in all of the data. The type should be Partial<T> instead of T.
@coffee-cup coffee-cup self-assigned this Sep 12, 2019
@coffee-cup coffee-cup added the enhancement ✨ New feature or request label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coffee-cup coffee-cup

Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coffee-cup