New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestore plugin: better type for `Fetching` and `FetchAll` #55

Open

coffee-cup opened this issue Sep 12, 2019 · 0 comments

Assignees

Labels

enhancement ✨

Collaborator

coffee-cup commented Sep 12, 2019 •

edited

Loading

The type of FetchData is currently

export type FetchData<T> =
  | { _fetching: true; _notFound?: never; data?: T }
  | { _notFound: true; _fetching?: never; data?: T }
  | { _fetching?: false; _notFound?: false; data: T };

It should be changed so that data is not a field on the result.

The text was updated successfully, but these errors were encountered:

coffee-cup self-assigned this

coffee-cup added the enhancement ✨ label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment