Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasize that the model file needs to be called model #161

Open
coffee-cup opened this issue Oct 7, 2019 · 2 comments
Open

Emphasize that the model file needs to be called model #161

coffee-cup opened this issue Oct 7, 2019 · 2 comments
Labels
enhancement ✨ New feature or request

Comments

@coffee-cup
Copy link
Collaborator

If you use the babel plugin, then the model must be defined in a file called model.ts or model.js. This isn't super clear in the docs and can be confusing (#132 (comment)). We should bring more attention to this fact.
@coffee-cup coffee-cup self-assigned this Oct 7, 2019
@mathieudutour
Copy link
Contributor

How about passing the path of the model as an option to the babel plugin? At least there isn't too much magic.

@coffee-cup
Copy link
Collaborator Author

Great idea

@coffee-cup coffee-cup added the enhancement ✨ New feature or request label Oct 7, 2019
@mathieudutour mathieudutour mentioned this issue Oct 7, 2019
Merged
@coffee-cup coffee-cup removed their assignment Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coffee-cup @mathieudutour