Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 unit tests associated with tint sometimes fail when running in GH Action #5772

Closed
1 of 17 tasks
stalgiag opened this issue Aug 28, 2022 · 1 comment · Fixed by #5773
Closed
1 of 17 tasks

3 unit tests associated with tint sometimes fail when running in GH Action #5772

stalgiag opened this issue Aug 28, 2022 · 1 comment · Fixed by #5773
Assignees

Comments

@stalgiag
Copy link
Contributor

stalgiag commented Aug 28, 2022

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

p5.js version

main

Web browser and version

N/A

Operating System

N/A

Steps to reproduce this

Open a pull request and look at the tests. If there isn't a failure re-run them or look at the time readouts next to the 'displaying images' tests.

I noticed this after I had to restart unit tests on two PRs included #5508 where the failed tests created some confusion.

Every time the GH actions run there is a chance that the unit tests in the 'displaying images' suite in images/loading.js will fail due to timeout (max 2000ms). The inconsistent behavior is likely due to the available resources on the virtual machine used to run the GitHub action.

These tests were added in #5471 . It is likely that these unit tests are a bit too resource-intensive for reliable testing on a VM. One possible fix would be reducing the size of the test image.

@davepagurek
Copy link
Contributor

Agreed, the test image can be smaller, I didn't consider it being slower on CI when I added those tests. I can clean them up and make them more efficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants