Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getURLParams() reference clarification #5035

Closed
16 tasks
tobyhoward opened this issue Feb 7, 2021 · 2 comments · Fixed by peilingjiang/b5#91
Closed
16 tasks

getURLParams() reference clarification #5035

tobyhoward opened this issue Feb 7, 2021 · 2 comments · Fixed by peilingjiang/b5#91

Comments

@tobyhoward
Copy link

How would this new feature help increase access to p5.js?

Most appropriate sub-area of p5.js?

  • Accessibility (Web Accessibility)
  • Build tools and processes
  • Color
  • [x ] Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Friendly error system
  • Image
  • IO (Input/Output)
  • Localization
  • Math
  • Unit Testing
  • Typography
  • Utilities
  • WebGL
  • Other (specify if possible)

Feature enhancement details:

getURLParams() returns undefined when called from a sketch run within the p5.js editor, because the code there is embedded in an iframe. getURLParams() works correctly when the sketch is viewed via the present or share urls. I suggest adding a sentence about this to the getURLParams() ref page at https://p5js.org/reference/#/p5/getURLParams.

cheers
Toby

@welcome
Copy link

welcome bot commented Feb 7, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@Aloneduckling
Copy link
Contributor

Aloneduckling commented Feb 25, 2021

I believe we have to do changes here

* Gets the current URL params as an Object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants