Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main navigation items are squeezed together #612

Open
whoisveroniica opened this issue Oct 19, 2024 · 5 comments · May be fixed by #633
Open

Main navigation items are squeezed together #612

whoisveroniica opened this issue Oct 19, 2024 · 5 comments · May be fixed by #633

Comments

@whoisveroniica
Copy link

whoisveroniica commented Oct 19, 2024

Increasing Access

Improves navigation accessibility.

Most appropriate sub-area of p5.js?

Navigation

Feature request details

Hi folks👋🏻 This is my very first contribution, so feedback is more than welcome! ❤️

I noticed items in the main navigation (as well as in a footer) are pretty squeezed together. It could negatively impact user experience, especially on mobile devices without precise pointers and lead to clicking an undesired link.

Screenshot of the main navigation items:
Screenshot of the main navigation items

Solution to this issue would be adding more padding between each item, similarily to jump to section:

p5js org_examples_ (2)

@limzykenneth
Copy link
Member

I'm generally in favor of giving these a bit of spacing and there are some general spacing issue elsewhere on the site but probably need a more coordinated approach to solve this though.

@whoisveroniica whoisveroniica linked a pull request Nov 12, 2024 that will close this issue
@whoisveroniica
Copy link
Author

@limzykenneth Thanks for your feedback!

but probably need a more coordinated approach to solve this though

What more coordinated approach do you have in mind, could you elaborate a little bit on that?

I've tried to fix the issue in #633. Let me know what you think of the current solution, thanks!

@limzykenneth
Copy link
Member

Mainly that this is not the only place where spacing is an issue, so we probably need a more thorough review of spacing and see if a more consolidated solution can help solve all if not most of the spacing issues we have.

@davepagurek
Copy link
Collaborator

@limzykenneth in the mean time, it looks like #633 makes the margins in the main nav match the margins in the section nav below (10px margin on items) so I think I'm ok doing the change to just the main nav for now to be consistent.

@limzykenneth
Copy link
Member

@davepagurek We can merge #633 for now if needed until we have more time to review the rest of the spacing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants