Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link on p5.js website page for "p5.js Web Accessibility" #511

Closed
iamniky opened this issue Sep 6, 2024 · 4 comments
Closed
Assignees
Labels
Bug Something isn't working

Comments

@iamniky
Copy link

iamniky commented Sep 6, 2024

Most appropriate sections of the p5.js website?

Home

What is your operating system?

Windows

Web browser and version

Firefox v130.0, though would affect all.

Actual Behavior

When users visit the URL https://p5js.org/contribute/web_accessibility/ and click on the hyperlink that is labeled "Using p5.js with a Screen Reader tutorial", they are met with a 404 error page:

Screenshot 2024-09-06 004138

Screenshot 2024-09-06 004201

Expected Behavior

We expect that when the users click the hyperlink labeled "Using p5.js with a Screen Reader tutorial", they are taken to a page with information regarding a tutorial about using p5.js with a screen reader.

Steps to reproduce

Steps:

  1. Go to https://p5js.org/contribute/web_accessibility/
  2. Click on respective link (listed in table below).
  3. Get a 404 error.

Solution:

Replace listed broken links to the correct links.

Source link text: Current link: Suggested link:
Using p5.js with a Screen Reader tutorial https://p5js.org/learn/p5-screen-reader.html ???

Would you like to work on the issue?

Yes, I'd like to work on the issue.

@iamniky iamniky added the Bug Something isn't working label Sep 6, 2024
@shourysingh07
Copy link
Contributor

I would like to work on this issue.

@Qianqianye
Copy link
Collaborator

Thanks @iamniky for reporting the bug. The link should go to https://p5js.org/tutorials/p5js-with-screen-reader/

Hi @shourysingh07, if you are interested in working on this, please go ahead and fix the link in this line and open a PR within p5.js library repo. Thank you!

@shourysingh07
Copy link
Contributor

Thank you @Qianqianye ! I've opened a pull request within the p5.js library repo.

Here is the PR Link.

@Qianqianye
Copy link
Collaborator

Closing this issue since it's fixed in PR #7254 in p5.js repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants