Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render Business Rule task #646

Closed
csouchet opened this issue Sep 23, 2020 · 3 comments · Fixed by #709
Closed

[FEAT] Render Business Rule task #646

csouchet opened this issue Sep 23, 2020 · 3 comments · Fixed by #709
Assignees
@benjaminParisel
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request good first issue Good for newcomers hacktoberfest Can be done during the Hacktoberfest
Milestone
0.5.0

Comments

@csouchet
Copy link
Member

csouchet commented Sep 23, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Render the Business Rule Task with the BPMN standard.

Depends on #237

Describe the solution you'd like

  • Update MxGraph Shape for the Business Rule Task.
  • Update snapshot for e2e test for the Business Rule Task

BPMN specification
image
image
@csouchet csouchet added enhancement New feature or request good first issue Good for newcomers BPMN rendering Something about the way the lib is rendering BPMN elements hacktoberfest Can be done during the Hacktoberfest labels Sep 23, 2020
@csouchet
Copy link
Member Author

Try the following icons (just the rectangle and its content):

@benjaminParisel
Copy link
Contributor

I will take it 👌

@tbouffard
Copy link
Member

@benjaminParisel cool!
You will have to test various business task icons, we have suggested some in comments of this PR.
In that situation, we usually do experimentations directly in Pull Requests like in #585 and vote for our preferred icon at that time. You can propose your own too.
As several are already proposed here, we can discuss about a subset prior the implementation to reduce the work to do.

@benjaminParisel benjaminParisel mentioned this issue Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminParisel benjaminParisel

Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request good first issue Good for newcomers hacktoberfest Can be done during the Hacktoberfest
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

[FEAT] Render business rule task benjaminParisel/bpmn-visualization-js
3 participants
@csouchet @benjaminParisel @tbouffard