Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Manage BPMN input source parsing warnings/errors #35

Open
tbouffard opened this issue Mar 5, 2020 · 2 comments
Open

[FEAT] Manage BPMN input source parsing warnings/errors #35

tbouffard opened this issue Mar 5, 2020 · 2 comments
Labels
enhancement New feature or request robustness Improvement or fix about performance, cutting edge, non happy path, ...

Comments

@tbouffard
Copy link
Member

tbouffard commented Mar 5, 2020

Is your feature request related to a problem? Please describe.
The lib should provide feedback and/or callbacks for any parsing errors/warnings that occurs on BPMN source input load.

Describe the solution you'd like
In the 1st implementation (#22), we skip this part as we only managed the happy path. As a consequence, some TODO remain in the code.
As for #21, we must manage all runtime parsing errors/warnings to provide feedback to the end user or allow the developer who integrates our lib to detect them.

Describe alternatives you've considered
N/A

Additional context
N/A

@tbouffard tbouffard added the enhancement New feature or request label Mar 5, 2020
@tbouffard tbouffard changed the title [FEAT] manage bpmn input source load errors [FEAT] manage bpmn input source parsing errors Mar 6, 2020
@tbouffard
Copy link
Member Author

This may be managed by #54

@tbouffard tbouffard added the robustness Improvement or fix about performance, cutting edge, non happy path, ... label Mar 13, 2020
@tbouffard tbouffard changed the title [FEAT] manage bpmn input source parsing errors [FEAT] manage bpmn input source parsing warnings/errors Jul 5, 2021
@tbouffard tbouffard changed the title [FEAT] manage bpmn input source parsing warnings/errors [FEAT] Manage bpmn input source parsing warnings/errors Mar 29, 2022
@tbouffard tbouffard changed the title [FEAT] Manage bpmn input source parsing warnings/errors [FEAT] Manage BPMN input source parsing warnings/errors Mar 29, 2022
@tbouffard
Copy link
Member Author

In v0.19.0, we introduced an internal mechanism to collect the parsing warnings. See #1479.
The warnings are currently only logged in the console, but the infrastructure is here to be able to return them at the end of the load processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request robustness Improvement or fix about performance, cutting edge, non happy path, ...
Projects
None yet
Development

No branches or pull requests

1 participant