Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render the Loop Marker of a Sub-Process #303

Closed
csouchet opened this issue Jun 16, 2020 · 2 comments · Fixed by #464
Closed

[FEAT] Render the Loop Marker of a Sub-Process #303

csouchet opened this issue Jun 16, 2020 · 2 comments · Fixed by #464
Assignees
@csouchet
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Milestone
0.1.7

Comments

@csouchet
Copy link
Member

csouchet commented Jun 16, 2020 •
edited
Loading

  • The marker for a Sub-Process that loops MUST be a small line with an arrowhead that curls back upon itself.
    The loop marker MAY be used in combination with any of the other markers except the multi-instance marker.
  • The marker for a Sub-Process that has multiple instances MUST be a set of three vertical lines in parallel.
    The multi-instance marker MAY be used in combination with any of the other markers except the loop marker.
  • The marker for an ad-hoc Sub-Process MUST be a “tilde” symbol.
    The ad-hoc marker MAY be used in combination with any of the other markers.
  • The marker for a Sub-Process that is used for compensation MUST be a pair of left facing triangles (like a tape player “rewind” button).
    The Compensation marker MAY be used in combination with any of the other markers.
  • All the markers that are present MUST be grouped and the whole group centered at the bottom of the Sub-Process.

image

All the markers that are present MUST be grouped and the whole group centered at the bottom of the shape.
image

image

image

Describe the solution you'd like
Modify the MxGraph shape for the sub-process.

Depends on #449
@csouchet csouchet added enhancement New feature or request BPMN support Something about the BPMN specification that the lib is already supporting or will support labels Jun 16, 2020
@csouchet csouchet added this to the Secondary set of elements milestone Jun 16, 2020
@csouchet csouchet changed the title [FEAT] Display the Marker of a Sub-Processes [FEAT] Display the Loop Marker of a Sub-Processes Jun 25, 2020
@csouchet csouchet changed the title [FEAT] Display the Loop Marker of a Sub-Processes [FEAT] Display the Loop Marker of a Sub-Process Jun 25, 2020
@csouchet csouchet changed the title [FEAT] Display the Loop Marker of a Sub-Process [FEAT] Detect the Loop Marker of a Sub-Process Jul 8, 2020
@csouchet csouchet added BPMN rendering Something about the way the lib is rendering BPMN elements and removed BPMN support Something about the BPMN specification that the lib is already supporting or will support labels Aug 4, 2020
@csouchet csouchet changed the title [FEAT] Detect the Loop Marker of a Sub-Process [FEAT] Render the Loop Marker of a Sub-Process Aug 4, 2020
@csouchet csouchet mentioned this issue Aug 4, 2020
Closed
@csouchet
Copy link
Member Author

csouchet commented Aug 5, 2020

When you get to the rendering:
Icon created by Thomas from "By Guilherme Furtado for the Noun Project"

image
loop_1.orig.zip

@csouchet
Copy link
Member Author

csouchet commented Aug 5, 2020 •
edited
Loading

The SVG converter mxgraph-svg2shape doesn't work with this image 😢

@csouchet csouchet mentioned this issue Aug 5, 2020
Merged
@csouchet csouchet self-assigned this Aug 5, 2020
@tbouffard tbouffard mentioned this issue Aug 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csouchet csouchet

Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request
Projects
None yet
Milestone
0.1.7
Development

Successfully merging a pull request may close this issue.

[FEAT] Render the Activity Loop Marker process-analytics/bpmn-visualization-js
1 participant
@csouchet