Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: load BPMN content from external file #18

Closed
tbouffard opened this issue Aug 3, 2020 · 3 comments · Fixed by #340
Closed

Examples: load BPMN content from external file #18

tbouffard opened this issue Aug 3, 2020 · 3 comments · Fixed by #340
Assignees
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Aug 3, 2020

With introduction of #14, #15 and #16 , the BPMN diagrams content are inline in the javascript code which make it quite long and disturb the user code reading as we mentioned in process-analytics/bpmn-visualization-js#433.
Find a way to put the BPMN content in a file and make the examples load this BPMN file (js script loaded as module + use import directive to load the file content?)

@tbouffard
Copy link
Member Author

The BPMN diagrams are now retrieved with javascript functions stored in dedicated files.

@tbouffard
Copy link
Member Author

We want the examples to work without a dev server, using file browsing. So we cannot use the fetch API to retrieve the diagrams.
See https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSRequestNotHttp

If we decide to drop the local file support browsing we will be able to put the bpmn content out of the js code, in dedicated files.

@tbouffard
Copy link
Member Author

This will be only implemented in project for now as we want to keep the local file support browsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants