Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add npm to dependencies #341

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

MaximDevoir
Copy link
Contributor

fixes #340

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should fix the windows problems 🤞🏼

@MaximDevoir
Copy link
Contributor Author

MaximDevoir commented Jan 19, 2021

Untested, but I think it'll work. Once the package is updated, I'll go back into Windows to test it.

Edit: 4.5.5 is confirmed to have fixed the bug

λ npx [email protected]
npx: installed 664 in 25.686s
create-probot-app [options] <destination>

  Argument <destination> is required.

  Example:
    create-probot-app my-first-app

  Run create-probot-app --help to see all options.

λ npx [email protected]
npx: installed 231 in 11.289s
Cannot find module 'npm'

@MaximDevoir MaximDevoir merged commit 8b3530d into probot:master Jan 19, 2021
@MaximDevoir MaximDevoir deleted the fix/add-npm-as-dep branch January 19, 2021 22:54
@github-actions
Copy link

🎉 This PR is included in version 4.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPA cannot find NPM module when running via NPX
2 participants