Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox yml #114

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Add Firefox yml #114

merged 2 commits into from
Oct 25, 2016

Conversation

LyzardKing
Copy link
Contributor

I tried to add a Firefox yml to test the new system.
From the extracted tarfile there's one file missing, libnss3.so.
This file is in the archive, so I assume it's removed somewhere in the Recipe file (could this be?)

- echo $DLD | cut -d- -f2 > VERSION

script:
- tar xfj ../firefox*.tar.bz2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the extraction of the ingredients in the script section of the ingredients section


script:
- tar xfj ../firefox*.tar.bz2
- mv firefox/* usr/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will then become mv ../firefox/* usr/bin/

- mv firefox/* usr/bin/
- find . -name mozicon128.png -exec cp \{\} firefox.png \;
- cat > firefox.desktop <<EOF
- [Desktop Entry]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find some existing Desktop file from the Mozilla repository instead?

@probonopd
Copy link
Member

probonopd commented Oct 25, 2016

From the extracted tarfile there's one file missing, libnss3.so.
This file is in the archive, so I assume it's removed somewhere in the Recipe file (could this be?)

Yes, it's on the list of libraries that should not go into AppImages.

But given that Firefox seems to be able to bundle it with no issues, I wonder whether we should make an exception here.

@LyzardKing
Copy link
Contributor Author

The regular firefox AppImage includes it. Without it it won't start

@probonopd
Copy link
Member

This would be one way of doing it:

app: Firefox

ingredients:
  script:
    - DLD=$(wget -q "https://www.mozilla.org/en-US/firefox/all/" -O - | grep -E "os=linux64&amp;lang=en-US" | cut -d'"' -f2)
    - wget -c $DLD --trust-server-names
    - echo $DLD | cut -d- -f2 > VERSION
    - tar xf firefox*.tar.bz2


script:
  - cp -r ../firefox/* usr/bin/
  - find . -name mozicon128.png -exec cp {} firefox.png \;
  - # Workaround for:
  - # https://bugzilla.mozilla.org/show_bug.cgi?id=296568
  - cat > firefox.desktop <<EOF
  - [Desktop Entry]
  - Type=Application
  - Name=Firefox
  - Icon=firefox
  - Exec=firefox %u
  - Categories=GNOME;GTK;Network;WebBrowser;
  - MimeType=text/html;text/xml;application/xhtml+xml;application/xml;application/rss+xml;application/rdf+xml;image/gif;image/jpeg;image/png;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ftp;x-scheme-handler/chrome;video/webm;application/x-xpinstall;
  - StartupNotify=true
  - EOF

post:
  - cp ../firefox/libnss3.so usr/bin # Override excludelist

@probonopd probonopd merged commit 21fc8f9 into AppImageCommunity:master Oct 25, 2016
@probonopd
Copy link
Member

libsoftokn3.so seems to be required also for other AppImages, so removing it from the blacklist for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants