-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firefox yml #114
Add Firefox yml #114
Conversation
- echo $DLD | cut -d- -f2 > VERSION | ||
|
||
script: | ||
- tar xfj ../firefox*.tar.bz2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do the extraction of the ingredients in the script section of the ingredients section
|
||
script: | ||
- tar xfj ../firefox*.tar.bz2 | ||
- mv firefox/* usr/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will then become mv ../firefox/* usr/bin/
- mv firefox/* usr/bin/ | ||
- find . -name mozicon128.png -exec cp \{\} firefox.png \; | ||
- cat > firefox.desktop <<EOF | ||
- [Desktop Entry] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you find some existing Desktop file from the Mozilla repository instead?
Yes, it's on the list of libraries that should not go into AppImages. But given that Firefox seems to be able to bundle it with no issues, I wonder whether we should make an exception here. |
The regular firefox AppImage includes it. Without it it won't start |
This would be one way of doing it:
|
|
I tried to add a Firefox yml to test the new system.
From the extracted tarfile there's one file missing,
libnss3.so
.This file is in the archive, so I assume it's removed somewhere in the Recipe file (could this be?)