Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace jax.ops.index_update with jax.numpy.at #3

Closed
murphyk opened this issue Mar 23, 2022 · 5 comments
Closed

replace jax.ops.index_update with jax.numpy.at #3

murphyk opened this issue Mar 23, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@murphyk
Copy link
Member

murphyk commented Mar 23, 2022

jax.ops.index_update has been removed (see jax-ml/jax@f51a05a) which breaks all the bandit code.
Please use jnp.at() instead.

@murphyk murphyk added the bug Something isn't working label Mar 23, 2022
@gerdm
Copy link
Collaborator

gerdm commented Apr 12, 2022

See the following lines:

from jax.ops import index_update

from jax.ops import index_update

from jax.ops import index_update

from jax.ops import index_update

from jax.ops import index_update

@dcbaugher
Copy link

I ran into this issue and resolved it as mentioned, but I'm having a really difficult time getting the code to run because I can't get any of the Kalman related classes(KalmanFilterNoiseEstimation and DiagonalExtendedKalmanFilter)to import from JSL. It's like they've been removed. I've been trying to reverse engineer it, but there's a lot going on in the code. I don't want to open an issue because I'm not sure if it's just me. Any advice would be very appreciated.

@murphyk
Copy link
Member Author

murphyk commented Apr 16, 2023

We plan to reimplement the bandit code on top of our new rebayes library in the new few weeks. Please check back later

@dcbaugher
Copy link

dcbaugher commented Apr 16, 2023

Thank you Kevin! On a related note, I'm very grateful for all the work you do/have done. Best, David

@gerdm
Copy link
Collaborator

gerdm commented May 7, 2023

Closed in 3ade11e

@gerdm gerdm closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants