Skip to content
This repository has been archived by the owner on Jul 14, 2024. It is now read-only.

Questions and suggestion #51

Closed
zgbkdlm opened this issue May 16, 2022 · 2 comments
Closed

Questions and suggestion #51

zgbkdlm opened this issue May 16, 2022 · 2 comments
Labels
question Further information is requested

Comments

@zgbkdlm
Copy link

zgbkdlm commented May 16, 2022

Very nice work 👍! I also had some implementations of filters and smoothers in https://github.com/spdes/chirpgp/blob/main/chirpgp/filters_smoothers.py, and I am wondering whether some of them can be integrated into this project if you need them.

Can I ask what is the difference between JSL and ssm-jax?

BTW, there is a license problem with the matlab codes https://github.com/probml/JSL/tree/main/jsl/sarkka-matlab. These are using GPL licesne. Your current project definition (somewhat) implies that they are part of your project, and that you are distributing their codes. This conflicts your MIT license.

@gerdm
Copy link
Collaborator

gerdm commented May 16, 2022

Hi @zgbkdlm!

We are currently looking for implementations of the Unscented Rauch–Tung–Striebel smoother and the Statistically linearized Rauch–Tung–Striebel. See #29, #28, and #27 for details. Feel free to PR if you have implemented any of those.

As to the difference between JSL and ssm-jax, I'll let @murphyk comment on that.

@gerdm gerdm added the question Further information is requested label May 16, 2022
@murphyk
Copy link
Member

murphyk commented May 16, 2022

Hi @zgbkdlm . We are currently building up ssm-jax as a new repo which will eventually replace JSL. Both are open source
projects so we would love your contributions, since you are obviously an expert. However, since the ssm-jax API is still in flux, it may be best to make a PR in the JSL repo for now, until the dust settles. (PS. I have removed Sarkka's matlab code, due to incompatible GPL license.)

@gerdm gerdm closed this as completed May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants