Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: introduce pairing support to protect against shoulder surfing #98

Merged
merged 77 commits into from
Jun 8, 2021
Merged

Feat: introduce pairing support to protect against shoulder surfing #98

merged 77 commits into from
Jun 8, 2021

Commits on Jun 8, 2021

  1. Feat: introduce binding support to protect against shoulder surfing

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    61a8f6b View commit details
    Browse the repository at this point in the history

  2. Refactor: minor code style changes

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7ff0ab0 View commit details
    Browse the repository at this point in the history

  3. Added more tests for binding and fixed usage variable name clientAuth

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    234a219 View commit details
    Browse the repository at this point in the history

  4. Make irma session fully support binding

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c754c0d View commit details
    Browse the repository at this point in the history

  5. Added support for responding to binding message in irma session

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4b316ca View commit details
    Browse the repository at this point in the history

  6. Introduce binding as a separate server status

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    44d39c4 View commit details
    Browse the repository at this point in the history

  7. Minor fixes for shoulder surfing feature

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f3a401d View commit details
    Browse the repository at this point in the history

  8. Changed outline of frontend endpoints for binding

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e9561e6 View commit details
    Browse the repository at this point in the history

  9. Added binding method to option request

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    97a06a4 View commit details
    Browse the repository at this point in the history

  10. Added binding method to session options struct

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ccea19e View commit details
    Browse the repository at this point in the history

  11. Improve comment to explain session state check

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    00d7ea7 View commit details
    Browse the repository at this point in the history

  12. Simplify unmarshalling of SessionInfo struct

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    758bd0f View commit details
    Browse the repository at this point in the history

  13. Some code refactors and improved error handling

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    0b223ac View commit details
    Browse the repository at this point in the history

  14. Code refactors in irma cmd package

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    0526c38 View commit details
    Browse the repository at this point in the history

  15. Refactored sessiontest to better integrate binding support

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    34f66b9 View commit details
    Browse the repository at this point in the history

  16. Refactor type of irma.BackendToken

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e3fe42d View commit details
    Browse the repository at this point in the history

  17. Refactor type of irma.ClientToken

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    edbd13e View commit details
    Browse the repository at this point in the history

  18. Refactor type of irma.FrontendToken

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6117add View commit details
    Browse the repository at this point in the history

  19. Include authenticationMiddleware in handleSessionGet

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    627b1b6 View commit details
    Browse the repository at this point in the history

  20. Improved error handling in irmaclient's session.go

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4e27593 View commit details
    Browse the repository at this point in the history

  21. Let handleGetInfo return an interface instead of two values

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    9d6f345 View commit details
    Browse the repository at this point in the history

  22. Do an early return in updateFrontendOptions

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    92c4e43 View commit details
    Browse the repository at this point in the history

  23. Remove duplicate assignment to binding method field

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    8a1e2bd View commit details
    Browse the repository at this point in the history

  24. Improved checkCache documentation

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    bc8963e View commit details
    Browse the repository at this point in the history

  25. Cancel sse channel when closing it prematurely

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    075b129 View commit details
    Browse the repository at this point in the history

  26. Move handleBinding to session.go + fix session options marshalling

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    599fe63 View commit details
    Browse the repository at this point in the history

  27. Split off request binding permission in separate function

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f8c6cad View commit details
    Browse the repository at this point in the history

  28. Improved request binding permission instruction

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7319dc3 View commit details
    Browse the repository at this point in the history

  29. Refactor: Move ClientRequest to irma package

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1a650f3 View commit details
    Browse the repository at this point in the history

  30. Small refactors and improvement of comments

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1fbedbe View commit details
    Browse the repository at this point in the history

  31. Minor improvements

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e79b135 View commit details
    Browse the repository at this point in the history

  32. Return error in getClientRequest and getRequest instead of RemoteError

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4ad743d View commit details
    Browse the repository at this point in the history

  33. Rename server.Status type and move to irma package

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5889b0b View commit details
    Browse the repository at this point in the history

  34. Use reflection to set maxVersion on irmaclient in tests

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3e6a02e View commit details
    Browse the repository at this point in the history

  35. Remove pointer usage for SessionDismisser in tests

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    fde6f41 View commit details
    Browse the repository at this point in the history

  36. Refactor BackendToken to RequestorToken

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    acdb670 View commit details
    Browse the repository at this point in the history

  37. Refactor FrontendToken to FrontendAuthorization

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    736c713 View commit details
    Browse the repository at this point in the history

  38. Improve error handling of SetFrontendOptions and BindingCompleted

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a056cf3 View commit details
    Browse the repository at this point in the history

  39. Make comment on ServerStatusBinding more clear

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    43e0692 View commit details
    Browse the repository at this point in the history

  40. Use early return in bindingHandler

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ffbddf8 View commit details
    Browse the repository at this point in the history

  41. Check error type in TestIssuanceBinding

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    cd3d9fb View commit details
    Browse the repository at this point in the history

  42. Implement Validate method for ClientRequest

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    8e9ea56 View commit details
    Browse the repository at this point in the history

  43. In cmd's postRequest return nil for transport when returning an error

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    96f7b87 View commit details
    Browse the repository at this point in the history

  44. Add library call to irma server to subscribe on statuses using channels

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ded859f View commit details
    Browse the repository at this point in the history

  45. Fixed ServerStatus refactor in TestIssueExpiredKey

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d33e947 View commit details
    Browse the repository at this point in the history

  46. Fixed spelling mistake in comment getSessionInfo

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7bd962d View commit details
    Browse the repository at this point in the history

  47. Fail if client diverts from protocol in handleGetClientRequest

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    491b557 View commit details
    Browse the repository at this point in the history

  48. Revert earlier change of returning pointers to session request in han… 

    …dleGetClientRequest
    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    85d66d8 View commit details
    Browse the repository at this point in the history

  49. Make GetSessionStatus to only accept requestor tokens

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e6ced48 View commit details
    Browse the repository at this point in the history

  50. Add comment to explain use of reflection in ClientRequest's Validate

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c9aa64b View commit details
    Browse the repository at this point in the history

  51. Use buffered channel for status updates

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    88e6ed2 View commit details
    Browse the repository at this point in the history

  52. Test for specific error when disabling binding after client connected

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2010853 View commit details
    Browse the repository at this point in the history

  53. Some more code style fixes

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    57c03d9 View commit details
    Browse the repository at this point in the history

  54. Fixed WaitStatus spawning multiple nil's on error channel

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d884570 View commit details
    Browse the repository at this point in the history

  55. Remove code duplication in extracting private fields using reflection

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f8f6627 View commit details
    Browse the repository at this point in the history

  56. refactor: rename GetSessionStatus server function to SessionStatus

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    0452d41 View commit details
    Browse the repository at this point in the history

  57. Updated CHANGELOG

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b784f64 View commit details
    Browse the repository at this point in the history

  58. Fixed handleBinding wrapping a SessionError in a SessionError

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c976ada View commit details
    Browse the repository at this point in the history

  59. Refactor: rename binding to pairing

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f44f557 View commit details
    Browse the repository at this point in the history

  60. Added missing Validate function for OptionsRequest

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    74bcf91 View commit details
    Browse the repository at this point in the history

  61. Introduce PairingRecommended field in Qr

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1d6db3d View commit details
    Browse the repository at this point in the history

  62. Shorten pairing recommended json tag and omit when false

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4adabfc View commit details
    Browse the repository at this point in the history

  63. Updated CHANGELOG

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4e5639e View commit details
    Browse the repository at this point in the history

  64. Remove pointer to bool in Qr struct

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b8f5a11 View commit details
    Browse the repository at this point in the history

  65. Improved CHANGELOG

    @ivard @sietseringers
    ivard authored and sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    451c612 View commit details
    Browse the repository at this point in the history

  66. refactor: decrease indentation level in wait_status.go

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    761a547 View commit details
    Browse the repository at this point in the history

  67. refactor: decrease indentation level in irmaserver.session.onUpdate()

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c211db0 View commit details
    Browse the repository at this point in the history

  68. feat: add new status endpoint for frontend

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e861fc7 View commit details
    Browse the repository at this point in the history

  69. feat: also add new statusevents endpoint for frontend

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e12a297 View commit details
    Browse the repository at this point in the history

  70. refactor: rename OptionsRequest to FrontendOptionsRequest

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a8bd786 View commit details
    Browse the repository at this point in the history

  71. feat: StartSession function and endpoint now return frontend-specific… 

    … data in new FrontendSessionRequest struct
    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ebf3ec5 View commit details
    Browse the repository at this point in the history

  72. feat: make chained sessions use the same frontend authorization token

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    0318100 View commit details
    Browse the repository at this point in the history

  73. refactor: rename ClientRequest to ClientSessionRequest

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    08ae605 View commit details
    Browse the repository at this point in the history

  74. fix: incorrect early return in SSE event handler

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    70713d0 View commit details
    Browse the repository at this point in the history

  75. feat: clarify FrontendOptionsRequest Validate error message

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c85ea36 View commit details
    Browse the repository at this point in the history

  76. feat: assign protocol version 2.8 to pairing

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4f8737c View commit details
    Browse the repository at this point in the history

  77. feat: always allow pairing when using chained sessions

    @sietseringers
    sietseringers committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2b248d7 View commit details
    Browse the repository at this point in the history