Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment: indexOf returns first occurrence #321

Closed
0xDatapunk opened this issue Sep 11, 2024 · 0 comments · Fixed by #359
Closed

comment: indexOf returns first occurrence #321

0xDatapunk opened this issue Sep 11, 2024 · 0 comments · Fixed by #359
Assignees
@cedoor
Labels
audit 🔍 This issue is related to an audit. documentation 📖 Improvements or additions to documentation good first issue Good for newcomers

Comments

@0xDatapunk
Copy link
Collaborator

zk-kit/packages/imt/src/imt.ts

Lines 152 to 156 in aa02c6d

/**
* It returns the index of a leaf. If the leaf does not exist it returns -1.
* @param leaf A leaf of the tree.
* @returns The index of the leaf.
*/

can we add to the comment that It returns the index of the first occurrence of the specified element in the array?
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Sep 11, 2024
@cedoor cedoor added documentation 📖 Improvements or additions to documentation audit 🔍 This issue is related to an audit. labels Sep 12, 2024
@cedoor cedoor added the good first issue Good for newcomers label Oct 24, 2024
@cedoor cedoor self-assigned this Dec 11, 2024
@cedoor cedoor moved this from ♻️ Grooming to 🏗 In Progress in ZK-Kit Dec 11, 2024
cedoor added a commit that referenced this issue Dec 11, 2024
@cedoor
docs(imt): add docs to indexOf function
b89eb2b 
re #321
@cedoor cedoor mentioned this issue Dec 11, 2024
Merged
7 tasks
cedoor added a commit that referenced this issue Jan 13, 2025
@cedoor
docs(imt): add docs to indexOf function (#359)
4425b09 
re #321
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✔️ Done in ZK-Kit Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

Labels
audit 🔍 This issue is related to an audit. documentation 📖 Improvements or additions to documentation good first issue Good for newcomers
Projects
ZK-Kit
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(imt): add docs to indexOf function privacy-scaling-explorations/zk-kit
2 participants
@cedoor @0xDatapunk