Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poseidon configuration params for Ethereum use case #85

Closed
arnaucube opened this issue Apr 5, 2024 · 4 comments · Fixed by #106
Closed

Poseidon configuration params for Ethereum use case #85

arnaucube opened this issue Apr 5, 2024 · 4 comments · Fixed by #106

Comments

@arnaucube
Copy link
Collaborator

Currently the tests that require usage of Poseidon are using the poseidon_test_config() params generator.
We need to have a specific method that offers the poseidon_config for the Ethereum use case (over Bn254's scalar field), to be used in non-test use cases that want to use the Ethereum Decider to verify the proofs. Ideally using the same config as in circomlib, noir-stdlib, etc.
And maybe the same for pasta curves (pallas and vesta) scalar fields.

@arnaucube
Copy link
Collaborator Author

tagging @ax0 as a knowledgeable person who could do this

@ashu-t3
Copy link

ashu-t3 commented May 29, 2024

Hi @arnaucube .

I am interested in this work. Could I get started on adding the configs from circomlib first for BN254.

@arnaucube
Copy link
Collaborator Author

Hi @ashu-t3 thanks for showing interest on this one. @ax0 started this one some time ago but got busy with other stuff, but just asked him and he almost have it locally and should be in a PR over the next days.

But if you're still interested, I'm thinking that a next step once this one is completed would be to do the same for the pasta curves fields, as they are the other main curves that seem that are going to be used apart from the bn254 for the Ethereum case. Would you like to do that one?

@ashu-t3
Copy link

ashu-t3 commented May 29, 2024

Thanks for getting back @arnaucube . Glad to do it for the pasta curves too. I am gonna take a look at the existing PR and then get started on it.

Do we want the pasta curves config to be consistent with o1js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants