fix: stricter href/field prop types for PrismicLink

prismicio · Jul 13, 2021 · 5dec44a · 5dec44a
1 parent 76ad782
commit 5dec44a
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/src/PrismicLink.tsx b/src/PrismicLink.tsx
@@ -23,16 +23,7 @@ export type PrismicLinkProps<
 	target?: string;
 	rel?: string;
 	children?: React.ReactNode;
-} & (
-	| {
-			field: prismicT.LinkField;
-			href?: never;
-	  }
-	| {
-			field?: never;
-			href: string;
-	  }
-);
+} & ({ field: prismicT.LinkField } | { href: string });
 
 const defaultInternalComponent = "a";
 const defaultExternalComponent = "a";
@@ -53,13 +44,13 @@ export const PrismicLink = <
 	const linkResolver = props.linkResolver || context.linkResolver;
 
 	const href =
-		props.href ||
-		(props.field && prismicH.asLink(props.field, linkResolver)) ||
-		"";
+		("href" in props
+			? props.href
+			: prismicH.asLink(props.field, linkResolver)) || "";
 
 	const target =
 		props.target ||
-		(props.field && "target" in props.field && props.field.target) ||
+		("field" in props && "target" in props.field && props.field.target) ||
 		undefined;
 
 	const rel =