Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly resolve types when using TypeScript's latest module resolution strategy #182

Merged
merged 5 commits into from
May 22, 2023

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR fixes the bug described in https://github.com/prismicio/prismic-typescript-template/pull/27

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@github-actions
Copy link

github-actions bot commented May 22, 2023

size-limit report 📦

Path Size
./dist/index.cjs 7.94 KB (+12.19% 🔺)
./dist/index.js 5.95 KB (+27.66% 🔺)
./dist/react-server.cjs 7.14 KB (+13.87% 🔺)
./dist/react-server.js 5.48 KB (+29.97% 🔺)

@codecov-commenter
Copy link

Codecov Report

Merging #182 (ef110a7) into master (436ebd9) will increase coverage by 0.12%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   99.44%   99.56%   +0.12%     
==========================================
  Files          21       20       -1     
  Lines        2531     2540       +9     
  Branches      129      129              
==========================================
+ Hits         2517     2529      +12     
+ Misses         14       11       -3     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/PrismicImage.tsx 100.00% <100.00%> (ø)
src/PrismicText.tsx 100.00% <100.00%> (ø)
src/PrismicToolbar.tsx 100.00% <100.00%> (ø)
src/SliceZone.tsx 99.09% <100.00%> (+<0.01%) ⬆️
src/react-server/PrismicLink.tsx 100.00% <100.00%> (ø)
src/react-server/PrismicRichText.tsx 99.29% <100.00%> (+<0.01%) ⬆️

@angeloashmore angeloashmore merged commit 27332f5 into master May 22, 2023
@angeloashmore angeloashmore deleted the aa/fix-types-resolution branch May 22, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants