Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Slice id property to key Slices in <SliceZone> when available #162

Merged
merged 6 commits into from
Aug 22, 2022
Merged

feat: use Slice id property to key Slices in <SliceZone> when available #162

merged 6 commits into from
Aug 22, 2022

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented Jul 28, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add support for Slice IDs, depends on prismicio/prismic-types#45

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@github-actions
Copy link

github-actions bot commented Jul 28, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/index.js 5.67 KB (+0.18% 🔺)
dist/index.cjs 7.3 KB (+1.59% 🔺)

@angeloashmore
Copy link
Member

Looks good 👍

I left a comment in @prismicio/types about renaming slice_id to id (see comment). If we do that, we'll need to update the property here as well.

@lihbr lihbr changed the title feat: support slice id feat: support slice ID Aug 2, 2022
@angeloashmore angeloashmore marked this pull request as ready for review August 22, 2022 23:52
@angeloashmore angeloashmore changed the title feat: support slice ID feat: use Slice ID to key Slices when available Aug 22, 2022
@angeloashmore angeloashmore changed the title feat: use Slice ID to key Slices when available feat: use Sliceid property to key Slices when available Aug 22, 2022
@angeloashmore angeloashmore changed the title feat: use Sliceid property to key Slices when available feat: use Slice id property to key Slices when available Aug 22, 2022
@angeloashmore angeloashmore changed the title feat: use Slice id property to key Slices when available feat: use Slice id property to key Slices in <SliceZone> when available Aug 22, 2022
@angeloashmore angeloashmore merged commit dd85581 into master Aug 22, 2022
@angeloashmore angeloashmore deleted the feat/support-slice-id branch August 22, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihbr @angeloashmore