fix: remove ESM package.json
declaration (fixes 'Element' is not exported from '@prismicio/richtext'
)
#122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR removes the explicit ES Module declaration by removing
"type": "module"
frompackage.json
.Declaring the package as an ES Module has caused issues in the following circumstances:
.mjs
extension to resolve correctly during server-rendered requests. This causes issues in build systems that do not recognize.mjs
(e.g. Create React App). This only happens when deployed to Vercel in production. (See Prismic preview crashing in Next.js production with 500 error #108).mjs
files are unsupported. It works with a.js
file extension, which breaks Next.js support..mjs
with"type": "module"
is supported, but breaks backwards compatibility with CRA 4.The most straightforward solution that ensures everything works out-of-the-box is to remove
"type": "module"
frompackage.json
. When the ecosystem is more aligned behind ESM, we can restore it to a proper ES Module.Fixes #117
Checklist:
🙃