Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatically assign keys to custom <PrismicRichText> components #118

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR automatically applies keys to custom components provided to <PrismicRichText>. Without the PR, React logs an error about missing keys if the a key prop is not explicitly given to each component.

More details: #114

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

🐺

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

size-limit report 📦

Path Size
dist/index.mjs 4.08 KB (+0.97% 🔺)
dist/index.cjs 5.63 KB (+0.65% 🔺)

@angeloashmore angeloashmore marked this pull request as ready for review January 26, 2022 00:31
@angeloashmore angeloashmore merged commit 9e609f6 into master Jan 26, 2022
@angeloashmore angeloashmore deleted the aa/rich-text-auto-keys branch March 31, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant