Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nested groups #341

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: support nested groups #341

merged 3 commits into from
Jun 20, 2024

Conversation

bapmrl
Copy link
Contributor

@bapmrl bapmrl commented Jun 5, 2024 •
edited
Loading

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Completes DT-2136.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@bapmrl bapmrl self-assigned this Jun 5, 2024
angeloashmore
angeloashmore approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

We can merge and publish once https://github.com/prismicio/prismic-types-internal/pull/77 is merged and published.

This was referenced Jun 5, 2024
Merged
Merged
lihbr
lihbr approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work 😍

@xrutayisire xrutayisire merged commit e6dc747 into master Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloashmore angeloashmore angeloashmore approved these changes

@lihbr lihbr lihbr approved these changes

Assignees

@bapmrl bapmrl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bapmrl @angeloashmore @lihbr @xrutayisire