Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type error in mapSliceZone #339

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR fixes a type error in mapSliceZone. The error was ignored via // @ts-expect-error in the source code, but the compiled output removed the comment. Thus, consumers that check the types of the installed package would throw a type error.

The typings have been fixed so // @ts-expect-error is no longer used.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@angeloashmore angeloashmore merged commit 638e87a into master Apr 12, 2024
12 checks passed
@angeloashmore angeloashmore deleted the aa/fix-mapSliceZone-types branch April 12, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant