-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add @prismicio/client/richtext
entry
#318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to declare the new entry point in the package.json
, remove the dependency on @prismicio/richtext
and refactor helpers to use the internal one no? Or do you want to do that in another PR?
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
========================================
Coverage 99.96% 99.97%
========================================
Files 50 57 +7
Lines 6251 6794 +543
Branches 332 374 +42
========================================
+ Hits 6249 6792 +543
Misses 2 2
☔ View full report in Codecov by Sentry. |
Types of changes
Description
This PR adds a new
@prismicio/client/richtext
entry.It ports all of
@prismicio/richtext
to@prismicio/client
as an isolated entry. An isolated entry was selected over exporting it adjacent to all other helpers to minimize accidental usage; rich text helpers are low-level functions to be used primarily in high-level framework SDKs, like@prismicio/react
and@prismicio/vue
.@prismicio/richtext
will be deprecated once this PR is published. All packages dependent on@prismicio/richtext
should be upgraded to@prismicio/client/richtext
.For more details behind this PR's motivation, see this thread: prismicio/prismic-richtext#63 (comment)
Migration guide
Update to the latest version of
@prismicio/client
:Replace all
@prismicio/richtext
imports with@prismicio/client/richtext
:Uninstall
@prismicio/richtext
:Checklist:
🦕