Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept an array of strings when using the not predicate type #241

Merged
merged 1 commit into from
May 26, 2022

Conversation

lihbr
Copy link
Member

@lihbr lihbr commented May 25, 2022

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

not predicate type was not aligned with API expectations, see: prismicio/prismic-types#35

Checklist:

@lihbr lihbr added bug Something isn't working documentation Improvements or additions to documentation labels May 25, 2022
@github-actions
Copy link

size-limit report 📦

Path Size
dist/index.js 4.02 KB (0%)
dist/index.cjs 6.88 KB (0%)

@lihbr
Copy link
Member Author

lihbr commented May 25, 2022

@angeloashmore, may I let you merge this one when you're ready with #240?

@angeloashmore
Copy link
Member

Perfect! I'll publish along with #240.

@angeloashmore angeloashmore changed the title fix: not predicate type fix: accept an array of strings when using the not predicate type May 26, 2022
@angeloashmore angeloashmore merged commit a1812fd into master May 26, 2022
@angeloashmore angeloashmore deleted the fix/not-predicate branch May 26, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants