Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix caching example by using .clone() method #218

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

sarunast
Copy link
Contributor

@sarunast sarunast commented Feb 2, 2022

The .json() cannot be resolved more than once for the same request

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix caching example mentioned #217

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

The `.json()` cannot be resolved more than once for the same request
@lihbr lihbr added the documentation Improvements or additions to documentation label Feb 3, 2022
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sarunast, thank you so much for taking the time to fix this one! Looking good to me~

@codecov-commenter
Copy link

Codecov Report

Merging #218 (15ea6f6) into master (b141ba7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          316       316           
  Branches        60        60           
=========================================
  Hits           316       316           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b141ba7...15ea6f6. Read the comment docs.

@lihbr lihbr changed the title Fix caching example by using .clone() method docs: fix caching example by using .clone() method Feb 3, 2022
@lihbr lihbr merged commit 52b455c into prismicio:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants